User talk:Tarvis

Feedback

Nice mod is comming

Hello Tarvis, it looks pretty cool! Maybe you can join your force together with Tycho and implement both yours improvement to the only extender..

I will enjoy your work and will try to help with testing :)

Also the playing Intro in MP3 would be great. I am now using Abram´s modded executable with mp3play.dll and my own moddified MP3 Intro music by Lorcan that was made for UFO:CF now probably dead project and it works great!

ElfKaa

I couldn't really say that I'm 'joining forces' with Tycho, it's more that I'm fixing little things on my own and he decides to add them if he wants. I can't really do much more than this because I don't have a deep understanding of the game code like Tycho does, all I'm doing is making tiny improvements to the actual Extender code. Because of that, I'm not even sure I understand the music code well enough for detecting intro music, so your best bet for that is probably just using AbraM's patch like you're doing. As far as I know, the only issue that comes from that is that the game will throw an error at you when you exit the game.

Essentially, I just take small issues I've noticed (like the window size option not taking into account window border thickness) and fix them myself instead of asking Tycho to do it, since he probably has more significant things to do. -Tarvis

Actually, if you have a solution or actual code (even better!) for a change, I'm always willing to look at it. I don't think anyone can be said to have a complete understanding of all the code. I have a good understanding of many parts, thanks to Seb and Xusalik's notes. Some people, like Kyrub, have a better understanding of areas depending on what area interests them. Tycho 23:26, 22 February 2013 (EST)

I took a look at the way Seb created the window for the game. He has the Extender just read the lines from the INI and create a window using those values. I guess he didn't realize or understand that those values would be the dimensions for the entire window and the playable area would be reduced by the size of the title bar and borders. In your fix, did you use the AdjustWindowsRectEx() function? I am having the hardest time getting a window created with the proper playable dimensions that compensates for various border widths. Tycho 11:12, 26 February 2013 (EST)

I just used AdjustWindowRect(). It doesn't actually resize the window on its own, all it does is edit the values of the rect you give in its first argument, and the next two arguments are WS_OVERLAPPEDWINDOW and then FALSE because those are the flags for the actual window which is created later. So, just make sure it's called before creating the window. I placed it in patches.cpp in his MyCreateWindowExA call. This also has to be accounted for when saving the variable back to the .ini during resizing, and that's done in video.cpp.

I've already handled all this though, I suppose I'll upload my code changes now. What diff making program should I use? I don't think TortoiseSVN would work since this project isn't really made from revisions. -Tarvis

EDIT: If it's easier, I could just upload the changed source files in their entirety (like last time), unless things have been added since the last release two days ago. Changes are d3d.cpp, video.cpp, patches.cpp and shortcuts.cpp -Tarvis

Great! I am looking forward to seeing them. As for the files, I think uploading the changed files is easiest. That way I can get a good idea of the changes and make sure they don't conflict with something else (In the rare case, two people would be making changes to the same areas.) Thanks for all your help! Tycho 21:13, 26 February 2013 (EST)

Okay, I just need to bring the changes to the 1.30 release first. I'll port them to TFTDExtender too, but that might take a bit longer because with my changes it gives me an error when exiting the game that I can't quite track down. (Otherwise works fine already) -Tarvis