Hey, sorry to pester you again. :) I've gotten access to IDA, as you suggested, and with it I'm making some slow progress toward my mod. I wanted to ask, though, do you know of any sort of tutorial or useful intro for it? The user interface is pretty obtuse, the built-in help has nothing useful, and I've been struggling just to make comments go where I want them to.

(I mean, I understand that it's meant for very advanced users, but Jesus, who writes an enterprise-grade utility and doesn't bother to implement an Undo function?!?)

Thanks again for your help! [[User:Phasma Felis|Phasma Felis]] 23:15, 16 June 2008 (PDT)

Okay, a little more progress since I discovered anterior comments. Couple of more specific questions: what's the difference between a "comment" and a "repeatable comment"? Or any of the several other types of comments, for that matter.

What exactly does "mov cs:word_102F9, ax" do? At first I thought it was just copying the accumulator into the data word at 02F9, but the "cs:" part is confusing. word_102F9 is 0, I think ("seg000:02F9 word_102F9 dw 0"). Does that mean it's copying AX into the current code segment, offset 0, modifying the code in progress? That seems odd.

Okay, one more and then I'll go to bed: what does "jmp short $+2" do? It looks like it just means "jump to next instruction", which is kinda redundant, but it could be "jump ''over'' next instruction", which...still seems unnecessarily verbose. I dunno. [[User:Phasma Felis|Phasma Felis]] 00:51, 17 June 2008 (PDT)

: The last two questions are actually general Intel 16-bit assembly ;)

: The cs in "mov cs:word_102F9, ax" is the 16-bit code segment base, yes. It *might* be self-modifying code, but more likely there is a C global or static variable that was implemented there and being updated. The "seg000:02F9 word_102F9 dw 0" is probably from C default initialization, but could be from an explicit initialization to 0.
::Back in the 16bit days, there were several memory models. My knowledge on this is quite rusty, but IIRC COM executables were using the "tiny" one which means that the code and data use the same segment (I assume you're working on the music TSR?). Modification of data via the CS segment is not necessarily self-modifying code. Also TSRs were usually signaled using software interruptions so the code most likely sets up an interrupt vector and bails out. e.g.:
seg000:0140 mov dx, 157h
seg000:0143 push ds
seg000:0144 push cs
seg000:0145 pop ds
seg000:0146 mov ax, 2566h
seg000:0149 int 21h ; DOS - SET INTERRUPT VECTOR
seg000:0149 ; AL = interrupt number
seg000:0149 ; DS:DX = new vector to be used for specified interrupt
seg000:014B pop ds
seg000:014C call sub_1067A
seg000:014F mov dx, ax
seg000:0151 mov ax, 3100h
seg000:0154 int 21h ; DOS - DOS 2+ - TERMINATE BUT STAY RESIDENT
seg000:0154 start endp ; AL = exit code, DX = program size, in paragraphs

::In this example (from music.com), there is code at 157h but IDA does not detect it. You can get there, type 'C' and create a new function. The code there is the most important. HTH [[User:Seb76|Seb76]] 12:10, 17 June 2008 (PDT)

::: There were at least six common memory models. *.COM not only assumed a single code and single data segment, it assumed their base addresses were the same. You get four more (with one segment of static data) by 1 or more than 1 of each of code and data segments [near and far pointer distinctions]. The last allowed more than 64K of static data.

::: XCOM most likely used one of the double-far memory models. -- [[User:Zaimoni|Zaimoni]], 9:31 Jun 19 2008 CDT

: "jmp short $+2" is jump over the next instruction, if the next instruction is 2 bytes. This probably came from an if-then-else in C (it's a common idiom in translating C to assembly). -- [[User:Zaimoni|Zaimoni]], 12:36 Jun 17 2008 CDT

:: I can see several instances of this in music.com for simple "return value" functions. Most likely a "feature" of the compiler. If used for padding, it is equivalent to 2 nop instructions, but takes only one cycle to execute. This was before deeply pipelined processors though ;-) [[User:Seb76|Seb76]] 12:10, 17 June 2008 (PDT)

Yeah, I sidelined off IDA onto general assembly there :) Probably a good thing, means I'm getting used to it. Sort of.

(Holy crap. I just discovered that hitting "P" (Create Function) in the right place is all it takes to enable graph display mode and give me a vast, improbably pretty flowchart of, well, a lot of stuff. I'd been wondering how to make that work.)

Anyway! Seb, you're correct, I'm working on the music TSR. I've pretty much figured out how the entry code works, setting up an interrupt vector and terminating, which I think is decent progress for three days' experience with x86 assembler. I did find a web reference to "jmp short $+2" [http://www.programmersheaven.com/mb/x86_asm/484/484/ReadMessage.aspx here], which suggests that it's "used to clear the cache, before going in or out of protected mode". Not entirely sure what clearing the cache does, but it's good to know.

Thanks to the both of you for your help. Seb, do you mind if I continue to ask questions here? I don't know where else it should go. Maybe we need a "ridiculous hacking ideas" section of the wiki... ;) [[User:Phasma Felis|Phasma Felis]] 01:10, 18 June 2008 (PDT)

:Hehe, sounds like fun. When I can find time to write a dll injector, I may add some stuff to it ;-) I'd start with increasing the max number of smoke entries. (Not possible right off the bat because it's using a static array instead of malloc-ed data :( ). Other ideas: fix the proxmine bugs, or maybe the disjoint base bug. I found the piece of code and it is not a simple "off by one" issue so it cannot just be patched in place... [[User:Seb76|Seb76]] 12:22, 18 June 2008 (PDT)

::Yeah, there's a lot of bugs and odd behaviors that could be fixed by just using larger arrays somehow. The 80-item limit causes all sorts of problems, the smoke limit, the 20-armed-proxmine limit...I wouldn't mind having more than 8 bases in the late game...stuff like that. [[User:Phasma Felis|Phasma Felis]] 12:42, 18 June 2008 (PDT)

Hmm. The loader thing looks wonderful, but as I'm using a dos version in dosbox I'm guessing I'm out of luck for now? Or are you a dos wizard as well? :)
[[User:Knan|Knan]] 12:35, 9 July 2008 (PDT)
:Using a loader coupled with dll injection, there is no limit to the size of what you want to patch. You can also use higher level languages instead of plain assembler. However it is windows specific (won't work on anything pre-XP because of CreateRemoteThread usage BTW). For CD music in DOS, [[User:Phasma Felis|Phasma Felis]] may be your ticket. I'm willing to help but as I said before, my knowledge of DOS is quite rusty. [[User:Seb76|Seb76]] 12:49, 9 July 2008 (PDT)
::It's really the equipment screen hack that looks compelling. Figure it might be unreasonably hard to do that in dos. But I can't seem to get the windows version to run at a reasonable speed these days, always far too fast. That's why I'm using dosbox. Ah well, have fun modding :) [[User:Knan|Knan]] 14:14, 9 July 2008 (PDT)
:Well, actually I have the speed issue too. It's just that setting the laptop to max battery and scroll speed to one is enough to work around the problem ^^. The geoscape has a sleep routine to prevent too fast updates. The mecanism is not present in the tactical part. [[User:Seb76|Seb76]] 14:45, 9 July 2008 (PDT)
:Edit: might be your lucky day. I made a modification, it should slow down the scroll now. Can you check? [[User:Seb76|Seb76]] 15:42, 9 July 2008 (PDT)

Seb76, since you appear to be on a roll with the findings lately, I thought I'd mention this as something to look out for if you haven't already found it. Can you track down the tables that determine a few other object properties that aren't stored in obdata.dat? I mean for properties like if it can cast light, what bullet image to use if the object is fired, whether its melee attack/mind probe/psi attacks are available for that item, etc. This would certainly allow for much more robust equipment modding. I'm guessing it'll be a part of the tactical.exe portion of the game. - [[User:NKF|NKF]] 19:56, 11 July 2008 (PDT)
:Only flares can cast light currently. It is not a property in obdata, but a hardcoded "objectType=0x1B" check. I can hack in a piece of code to enable light for some other object types, but we'll need a way to say which ones do (can be done in the ini file but it would not be clean. Maybe we can find an unused bit in obdata.dat and arrange that...). [[User:Seb76|Seb76]] 14:12, 12 July 2008 (PDT)
:Edit: the routine that populates the item menu has everything almost hardcoded too: stun, mind probe, psi-amp actions, scanner and medkit are all hardcoded by object type. The rest uses known flags from obdata. [[User:Seb76|Seb76]] 15:18, 12 July 2008 (PDT)
:Edit2: playing with the heavy laser mod, I found the data for bullet image/sound. It is located at offset 0x6D1F8. Each entry is organized like that:
struct {
short bulletVisual;
short shootSound;
short impactSound;
short impactAnimation;
}
Entries are sorted per [[OBDATA.DAT]] ID (i.e. the first entry is for pistol, the 0x12th for heavy laser, etc.) [[User:Seb76|Seb76]] 15:31, 2 August 2008 (PDT)

: Ah, that'll help with some modding. Although I just remembered something that I was going to ask at the time - but completely forgot about. What controls how the weapon is displayed while in the soldier's hands? I mean, the pistols are displayed with the weapon extended in the firing position while most other weapons are held across in both hands (mimicking one/two handed items). Would this be hard coded as well in addition to the unique item actions? -[[User:NKF|NKF]] 17:43, 2 August 2008 (PDT)

== Error running UFOExtender ==

Hi Seb76. I've tried running your UFOExtender as I want to slow down the scrolling in the tactical view. However I get the following error message:

C:\Games\X-com\UFO Defense\UFOLoader.exe
This application has failed to start because the application configuration is incorrect. Reinstalling the application may fix this problem.

Any ideas what's going wrong? I'm on Win XP running Collector's Edition of UFO. --[[User:Col w|col_w]] 05:34, 12 July 2008 (PDT)
:Hum, looks like the error you get when there is a missing DLL. I compiled using Visual Studio 9.0 Express Edition, maybe you don't have the runtime installed? You can get it [http://www.microsoft.com/downloads/details.aspx?FamilyID=9B2DA534-3E03-4391-8A4D-074B9F2BC1BF&displaylang=en here]. Tools like [http://www.dependencywalker.com/ dependency walker] can help identify missing DLLs. Also what OS are you using (service pack number)? I don't have Vista here to test so it may only be running in XP SP2. Anybody can report it running on Vista? For sure it won't work on Win9x. [[User:Seb76|Seb76]] 09:02, 12 July 2008 (PDT)
::Yeah, visual xyz runtime dlls need to be included with things you compile with visual xyz. A common complaint when running small hacks under Wine on Linux as well, since you usually install just a very few programs on each virtual windows install, so it's unlikely some other program installs the dlls for you. [[User:Knan|Knan]] 17:08, 12 July 2008 (PDT)
:Especially since they made up that manifest stuff. Supposed to solved DLL hell... Well, so far it caused me more trouble than it solved issues. The funny part is when you install a new VS service pack on your build servers and have half the development team freak out because their target system won't boot the latest piece of code... [[User:Seb76|Seb76]] 18:04, 12 July 2008 (PDT)
Awesome, that fixed it! Now I can enjoy this classic game once again. Love the language screen joke too :) Many thanks --[[User:Col w|col_w]] 11:08, 12 July 2008 (PDT)
:My pleasure man. Glad you enjoyed it ;-) [[User:Seb76|Seb76]] 12:07, 12 July 2008 (PDT)

== UFOloader and Xcomutil ==

Hey Seb76 awesome work with this patch! Just wondering though if it would be possible to run this together with XcomUtil somehow. Thanks!
Oh and btw when's the TFTD version coming out? ;-)
[[User:J'ordos|J'ordos]] 14:09, 24 July 2008 (PDT)
:You can try this version: [[Image:UFOExtender-dev.zip ]]. I did not really have time to test it. Use the modified batch and keep me posted ;-) You'll get a crash if you activate the patch to disable the introduction movie. I checked the equipment screen patches, they were OK. TFTD will wait till I'm satisfied with the XCOM version. Anyway, I'm not in a disassembling frenzy right now :p [[User:Seb76|Seb76]] 15:29, 24 July 2008 (PDT)

:: Hey fast response, thanks! I tried the new version but unless I'm missing something I've been unable to get it to include f0dder's bugfix loaders. I edited the ini file's Executable= to 'xcloader.exe', xcomutil's included bugfix loader, and when I run UFOloader.exe directly it works fine, but when using your modified runxcomW.bat it seems to be disregarded. This was not the case with your previous version. (I actually thought of modifying runxcomW.bat like that :-) ) Can't seem to find any reason for it in runxcomW.bat.
:The only modification I did to this version is forward the parameters passed to the loader to the XCOM executable (geoscape is passed an argument which tells it if it needs to start from scratch, or use the data from the missdat folder). Also it cannot work with f0dder's patch the way you tried: doing so, you are patching the xcloader binary itself, which obviously is not what you want.
:Edit: I added a "Video Pitch" bug fix to compensate for the incompatibility of the 2 loaders ;)
:: also a minor note, but on a fresh xcom install the console echoes a read error on MISSDAT\saveinfo.dat (I assume this is the work of xcomutil) and minimizes Xcom to the tray. It still works fine though.
:: while on the subject of minor notes the 'Rank In Inventory=' in your ini file actually has the letter O instead of the number 0 by default ;-)
:Hm, I guess that's what you get when experimenting stuff at 1:00 am ;-) (GMT+2 here)
:: edit: I decided to do some testing first by manually disabling directdraw to circumvent the bugfix loader problem. Unfortunately the game crashes as soon as I enter tactical combat (when it should go to the equipment screen) even when all features are disabled. But unless I delete the MISSDAT folder's contents the next time I run runxcomW.bat I can hear the battlescape music playing. Unfortunately the batch file seems to get stuck in an infinite loop or something as it just keeps starting xcom over and over until it finally kills my system! :-) (all my base really belong to you ;-) )
:I start the runxcomw.bat batch from a shell and I have to do a "ctrl-C" between phases . Maybe it is because I replied yes to "Do you want to see XcomUtil messages after combat?"
:: using the previous version I can enter battles just fine, but none of the UFOloader features work.
:Did you try disabling every XComUtil features? I don't know how extensively it modifies the main executable. Here it works with the following config: replied "no" to everything while installing XComUtil (so that only executable splitting is done), enabling only equipment screen patches with my loader, and starting via the attached batch file. I can start a new game, down a UFO, go into tactical mode and go back to the geoscape view after taking down all the aliens. Did you try renaming UFOLoader.exe into xcloader.exe? It might work [[User:Seb76|Seb76]] 12:21, 25 July 2008 (PDT)

:: Thanks for your efforts, but still no luck. I downloaded the new version and did a fresh install of xcom. Running the UFOloader without xcomutil works fine (with your directdraw patch I get a ~3sec pause everytime the game zooms in/out on an interception though, which does not occur with f0dder's patch). Running xcomutil without the UFOLoader also works fine (using ctrl+C). I then did another fresh install and put the both of 'em together. I enabled the equipment screen patch and the directdraw fix on UFOLoader and told xcomutil to use f0dder's loader, answering no to all other questions. Renamed UFOLoader.exe to xcloader.exe and started runxcomW.bat. The game crashed when it should go to the equipment screen. (no ctrl+C possible) Disabling the equipment screen patch and/or enabling xcomutil's messages after combat yielded the same result. :(
:About the 3sec pause, it may be related to the musicfix that f0dder's patch does: it runs the MCI commands in a separate thread to remove the pause due to synchronous calls (with the unpatched version, there is a "slight" pause (~0.5sec on my computer) each time the music changes). Do you have the same pause in the main menu? Also if you activate the PSX music patch (even with no CD in the tray), it should remove the pause (if it is indeed the same problem). For your crash, I haven't got a clue. Maybe it's time I release the source code so people with different configurations can try more stuff. I know there are imaginative people out there ;-) [[User:Seb76|Seb76]] 07:02, 27 July 2008 (PDT)

:: Ah that fixed the delays, thanks! Strangely the battlescape now works fine (using ctrl+C) as long as I don't enable the equipment patch with xcomutil... Don't know about the other fixes&flags. I'll do some more testing. [[User:J'ordos|J'ordos]] 10:31, 27 July 2008 (PDT)

:: edit: quick testing reveals that it actually crashes exactly 1 times in 2, apparently regardless of what fixes are on. (though I did not yet test any xcomutil features) I guess it's probably related to one of the MISSDAT files? [[User:J'ordos|J'ordos]] 10:37, 27 July 2008 (PDT)
:: edit2: OK here's what I have so far: It crashes if the previous mission worked. It works if it crashed on the previous mission. If I delete the contents of the MISSDAT folder it always crashes until I do a mission without xcomutil and/or without the loader. After that the normal rules apply. (i.e. next mission I play with both xcomutil&the loader it'll crash, as the previous mission worked, but the next one will work again) very strange :s Note that I did not yet try to play out a full mission, I always aborted on the first turn. Hope you can narrow the problem down a bit this way :-) [[User:J'ordos|J'ordos]] 10:50, 27 July 2008 (PDT)
:Can you give me the address of the error when it crashes? (accessible in the crash window dialog)[[User:Seb76|Seb76]] 11:29, 27 July 2008 (PDT)

:: There is nothing when it crashes, not even the console remains. Unless you're talking about a log file?
:I was talking about the "a program has cause xxx to close unexpectedly" (or whatever it is in the US version) dialog box. This looks more like a silent crash (the worth case). I modified the loader and it looks better. I still have the "ctrl-C" issue however. [[User:Seb76|Seb76]] 12:38, 27 July 2008 (PDT)

:: <3 don't know what you did but the latest version works perfect! Just did 3 missions in a row, restarted xcom and did another 2 (only actually completed one of 'em tho :) ) without any crashes at all! *crosses fingers* I enabled all the settings I wanted in both xcomutil and the UFOLoader without problems. Thanks Seb, excellent work! ;-)
:: oh and the ctrl+C thing is a problem in the xcomutil batch file, it's not your program's fault. The Xcopy commands in the runxcomW.bat file are missing a /Y parameter. Here's a link to the xcomufo.com forum thread discussing it for anyone interested: [http://www.xcomufo.com/forums/index.php?showtopic=242025489]
:: Whew, was quite a ride... Now, where's my ammo clip fix? ^^
:Thanks for the feedback, it is good to know that it is possible to have this work with xcomutil. BTW, the fix I did in the test version is also in the latest package with the ammo clip hack ;-) [[User:Seb76|Seb76]] 16:16, 27 July 2008 (PDT)
:::After spending an hour with reading through this double discussion and trying to find the right batch file in the old archives and make the game work, I decided to put your '''Xcomutil + UFOloader solution''' here: [[Image:RunXcomW.zip]] with a simple explanation. Hope you don't mind.--[[User:Kyrub|Kyrub]] 15:43, 8 September 2008 (PDT)
::::Actually you don't need the modified runxcomw.bat file, the way I do it is I tell xcomutil to use f0dder's loaders and then I simply replace xcloader.exe (xcomutil's included f0dder patch) with UFOLoader.exe! [[User:J'ordos|J'ordos]] 05:01, 9 September 2008 (PDT)
: Hey there, I've read about this project and I'm wondering if I can ran it with XComUtil but I play with the DOS versions (through DosBox) and thus use RunXCom. [[User:Hobbes|Hobbes]] 16:27, 13 September 2008 (PDT)
::Sorry there, this project uses modifications of the binary so it'll work only on the windows version. Why do you have to stick to the DOS version BTW? [[User:Seb76|Seb76]] 04:29, 14 September 2008 (PDT)
:::DOS version was the first I played and I prefer its sounds (specially the alien death cries). I also prefer the DOS bugs (some on CE are too annoying). Thanks anyway :) [[User:Hobbes|Hobbes]] 11:26, 14 September 2008 (PDT)
:::Hmm, something I remembered: IIRC, XComUtil splits the binary of CE into Tactical and Geoscape, in order for it to run with CE. I think I'll download your program and give it a try [[User:Hobbes|Hobbes]] 11:34, 14 September 2008 (PDT)
::::No success, doesn't surprise since I have the barest clue of what I should be doing. [[User:Hobbes|Hobbes]] 11:44, 14 September 2008 (PDT)
::There's no way it could work like that, windows binaries cannot run in DOS environment; split binaries or not. If you're pissed about a particular bug, just tell. I may be able to fix it ;-) Concerning the sounds, I don't know exactly what is the problem about CE version. If someone can give some details, I may have a look at that too. [[User:Seb76|Seb76]] 12:09, 14 September 2008 (PDT)
:Hey Seb is it possible the latest versions of your extender don't work with xcomutil anymore? Did you drop support? Love the new features but I rather miss xcomutil's automatic re-equipping :) [[User:J'ordos|J'ordos]] 12:58, 26 April 2009 (EDT)
::Yeah, it is possible ^_^ But you now, it was never officially supported, it worked more or less by chance ;-) As I said on the forum, it might be possible the older version of the loader still works (you can use the old loader with a recent patcher DLL, it should be OK), but I got little feedback so I don't know if I'm correct... [[User:Seb76|Seb76]] 16:13, 27 April 2009 (EDT)

== Heavy Laser Mod ==

Hey Seb, I've been trying the new heavy laser. It's a cool idea, adds some new options during battle :) But I think currently the full auto option is overpowered. I hardly use the burst mode at all. I'd suggest lowering the accuracy and/or (if possible) reducing the amount of shots fired? Currently when I see a single alien I use full auto (can't miss with 10 shots), when I see a terror unit I use full auto (2x2 + 10 shots = dead terror unit :) ), and when I see a group of aliens I also use full auto (10 shots > 5 shots). A few units still standing? Bring on the next heavy laser.
Also because these new fire modes don't mind line of fire restrictions cover won't help aliens at all (unless the cover is strong enough to withstand HL power). Just use full auto to blast through any house that's in the way and in most cases it'll still kill the alien as well. (do need to make sure no agents/civilians are standing in the line of fire though)
Should note that ATM I'm still only dealing with sectoids and the occasional floater. Will let you know how it fares against the later races.
[[User:J'ordos|J'ordos]] 05:44, 31 August 2008 (PDT)

OK, it's cool but it really is overpowered. Accuracy must be lower in Auto modes than in Snap, that's basic in the game. If you assume the Heavy Laser is somehow better optimised for autofire than the Laser Rifle, and set the TUs for normal Auto at say 30% (vs 34% with Laser Rifle) that would let you get off 3 bursts, which would be better. (I could live with the idea that you can also only fire 3 snap shots). Then your "Full Auto" mode would be 100% TUs for 10 rounds and your "Burst Mode" could be 50% TUs for 5 rounds, and that would be consistent with the 'standard' Auto mode. But the accuracy per shot needs to be much lower. I would suggest the base Accuracy per shot is reduced to 33% (one third less than Snap, similar to a Laser Rifle). You are still making the weapon MUCH more effective this way. [[User:Spike|Spike]] 12:47, 1 September 2008 (PDT)

: On further analysis, even this is too powerful. The stats I just cited would give firepower only a fraction less than a Heavy Plasma - with much lower cost, unlimited ammo and easier-to-reach technology. That's not balanced. Unfortunately, you can't really go above 6 shots per turn without unbalancing the game, as none of the 2 handed weapons fire more than 6 shots/turn. So the TUs for Auto need to be 34%-40%, and you can't really have it fire more than 6 shots per turn even in the Full Auto mode. I would suggest Auto = 35%, Burst = 75%, Full Auto = 80%. Burst and Full Auto only fire 6 shots. Burst Mode fires 2 shots each at 2 waypoints, and a further 2 rounds spread in between the 2 waypoints. Full Auto fires one each at 2 waypoints and 4 shots spread between the waypoints. And maybe the Burst Mode should be the more expensive one as it is more 'concentrated' fire. The reason you can't really exceed 6 shots per turn, even if you reduce the accuracy drastically, is because otherwise you create a super-effective shock weapon at point blank range (and a super effective terrain-clearing weapon). Somehow the 'shock power' in particular seems inappropriate for something as clumsy as a Heavy Laser. To rationalise it, think of it this way - it's not a machinegun, it's an energy weapon. The 'cyclic rate of fire' is limited by the energy circuitry as much as anything else. So squeezing six shots per turn out rather than 3 (the limit with Snap fire) is a pretty good improvement. With the Auto Mode I've suggested here, you have still double the 'shock' firepower of the Heavy Laser at short range, and increased its firepower by two thirds at longer ranges. Not a bad way to put some life back into a weapon that otherwise has very limited uses. Probably in the 'Area' modes (Burst / Full Auto) the Accuracy should drop, say to 25% (vs 33% in standard Auto). [[User:Spike|Spike]] 13:48, 1 September 2008 (PDT)

Ok I finally shut down my NeXCom Workstation and turned out the lights in the Bean Counter's Department at X-Com HQ - and headed down to the Armoury. I checked out one of the new, experimental Super Heavy Auto Lasers and ducked onto an Avenger heading into a hot LZ.

Seb, let me tell, you, it was SPECTACULAR! You are the Ayatollah of Rock-and-Rolla! I was like Jesse Ventura in Predator, carving up the jungle with his minigun. I love your gun. It is too cool. It must not be nerfed. So I have another suggestion for your coding skillz:

See if you can get the "hidden item", Gatling Laser, working. Add your Super Heavy Auto Laser as a new item, using the Gatling Laser image and OBDATA entry. I don't know if you can add a new Research option or a new Manufacturing option. If you can't, maybe you can offer it to Purchase (once Heavy Laser is researched, or perhaps Laser Cannon). Given the power of the weapon (as spec'd above), the cost to buy or manufacture should be similar to a Heavy Plasma: around a total cost of $164K to manufacture (including ''all'' costs) or around $225K to buy. As a quick hack, for the time being, if you are still using the Heavy Laser object for the Super Heavy Auto Laser (with 10 shot Full Auto), increase the manufacturing costs and buy/sell prices to roughly the same as the Heavy Plasma. [[User:Spike|Spike]] 13:29, 3 September 2008 (PDT)

:Thanks for the nice feedback! The initial idea for this mod came when watching a Laser Squad speedrun (never played the game myself) and seeing the guy waste several baddies with one auto-shot sweep (in this game you can also select the number of shots when auto-firing). I chose to try a modification of the heavy laser for 2 reasons: everybody agrees to say that the default one sucks and second, since it uses no ammunition there is no need to handle out-of-ammo conditions. I personally see this weapon more as a recipe for new doors than a direct way to kill aliens. Several things could nerf it a bit but I didn't try them yet:
:*make accuracy lower and lower during a burst (to account for the laser lens deformation caused by overheating). This would restore the advantage of cover and make people thing twice before firing when a friendly unit stands in front
:*reduce accuracy even further when shooting out of sight (this was mentionned in another post)
:*change the damage model and reduce the probability that terrain is destroyed when shot
:*have a cooldown period where the weapon is not useable (not sure if it's feasible though)

::Yeah cooldown periods! Then restore functionality of the melee HIT command. Hey it worked for incubation: time is running out. ^^ [[User:J'ordos|J'ordos]] 16:27, 7 September 2008 (PDT)
:::Hm, I already cannibalized the unused "open" and "close" actions for the heavy laser mod, there is no more room for a new "hit" command. Unless... ;-) [[User:Seb76|Seb76]] 11:28, 8 September 2008 (PDT)

:OK, here is the last draft before I finalize:
:*Shooting the HL will cost ~50 energy so you won't be able to abuse it (the shooter will be a sitting duck)
:*Each shot of a burst will reduce the accuracy (amount not determined yet)
:*The [[User:Seb76#Range_Based_Accuracy|Range Based Accuracy]] will always apply to the HL
:If everybody likes it, I'll got with that. Any comment? [[User:Seb76|Seb76]] 09:16, 22 November 2008 (CST)

Sounds good to me. [[User:Spike|Spike]] 17:25, 22 November 2008 (CST)
:OK, here we go. I won't tell you exactly what I did, just give me your feedback ;-) [[User:Seb76|Seb76]] 05:24, 23 November 2008 (CST)

It's been a while, but recently tried your newest version and it seems the heavy laser is bugged? No matter which firing mode I choose it is extremely inaccurate and a lot of shots after travelling in one direction suddenly 'deflect' into another direction for some reason. It's a miracle none of my own guys were hit :) [[User:J'ordos|J'ordos]] 12:41, 28 February 2009 (CST)
:It may have been broken by other stuff indeed. I'll have a look [[User:Seb76|Seb76]] 17:29, 28 February 2009 (CST)

Hey, is it just me or is full auto not affected by range based accuracy, while burst is? I am using the RB accuracy mod on all weapons, and maybe that is affecting it. All I know is, even at long distance, full auto shows full accuracy. Not sure if the burst mode is showing the RB decrease I programmed or not though.
--[[User:Talon81|Talon81]] 06:01, 14 April 2009 (EDT)

:The heavy laser and range based accuracy stuff were developped in parallel and merged later. It is almost sure that things will go wrong if you activate both ;-) I could reproduce some issues and will try to fix them. BTW, I got no feedback for the "shortcuts" patch. Is it broken that badly that nobody wants to have it fixed? [[User:Seb76|Seb76]] 17:00, 18 April 2009 (EDT)

I just used an unpatched version (CE, as I always use), and used your patch on it. The only things I even activated in the patch are the video fix so it was playable, the heavy laser mod, and the accuracy mod. Still have the same problem, so yeah... they don't work well together at the moment. But... I am hooked on the accuracy mod, so I guess Ill just deal with it and not use full auto. As far as shortcuts go... I had enabled it at one time, but I found that I just never used them. Maybe I will try to use it a bit to give you some feedback. I added a comment for alien bases, too, btw. --[[User:Talon81|Talon81]] 15:18, 19 April 2009 (EDT)

== Wish List please please please ==

=== New and Outstanding Requests ===

* Remember soldier load outs from last mission and re-equip accordingly. Or maybe just prevent units from taking more than they can carry. Removing grenades first, then magazines and ammo and lastly guns.

* Make it so you can drop more than one screen worth of stuff in the pre-mission equipping phase.

* Allow human side soldiers to reaction fire in their currently saved Reserved Fire mode - eg to take Autofire or Aimed reaction shots. That would be very, very cool. It would also be a balanced trade-off, if these Reacting soldiers were not allowed to 'switch' to Snap fire after they no longer have the TUs left to use their Reserved mode.

: Has this been completed via the "Save Reserve Mode" feature? Not entirely I guess as Reaction fire is still always in Snap. To be honest that's not a bad thing. [[User:Spike|Spike]] 08:54, 23 November 2008 (CST)

* Implement your 'Area Fire' (as per Heavy Laser) for '''all''' large automatic weapons (AutoCannon, Heavy Plasma) or maybe just for all automatic weapons, period. It would be very handy for Autocannon bursts to cover a wider area, firing a narrow burst is often not what you want at all in many tactical situations. There might be a problem implementing this for Plasma weapons, if you couldn't persuade the Aliens' AI to use the Area modes - it wouldn't be fair.

* Close down Exploits. (I've just been reorganising the Exploits pages so it's on my mind.) Maybe this is pointless for those who have the willpower just to abstain from using Exploits. But as these are actually bugs I think it would be good to fix them. The worst exploits in my opinion are:
** [[ExploitsA#Free Manufacturing|Free Manufacturing]]. Probably needs to add a check that the manufacturing project has >0 units before allowing it to start.
** [[ExploitsA#Free Wages|Free Wages]]. Pay wages regardless of whether staff are in transit. They are on the payroll after all. This has a drawback that you pay twice (1.5x) for staff you hired very near the end of the month, which would affect some styles of gameplay.
** [[Tactical Exploits]]: The worst ones are the Collision Detection bugs, those I imagine are '''hard''' to fix.
** Eliminate "infinite fuel" exploit for conventional aircraft.
* Side-arm throws for grenades: It would be nice if the game could first check for a direct fire solution (side-arm throw or straight throw) for a grenade attack, if the target is in range for a straight throw, Range for straight throws would be reduced (to 1/4 or so of the parabolic range). It would only go on to attempt the indirect fire solution (parabolic vertical throw) if the direct fire attack returns "no line of fire". This would avoid a lot of the "hit the ceiling" issues with grenade indirect fire.[[User:Spike|Spike]] 08:54, 23 November 2008 (CST)

* With View All Locations, put some kind of indicator or (better yet) counter on the Geoscape screen when there are UFOs in flight. In case the UFO is on the other side of the world from where you are currently looking. '''-OR-'''
* Make the world rotate at normal speed (i.e. once per 24 hrs. Rotation starts after say 12 or 24 hrs of looking at the Geoscape and not touching anything. Stops again if you touch the globe controls.
* Make Aliens able to pick up a weapon if they are empty handed! Or just make them pick up anything Alien in their square, if that's easier. Maybe move them towards a weapon if they have no weapon - much harder to do I suppose. But at least, if they are empty handed and happen to walk over an Alien weapon, pick it up! See discussion [[Wish List#Alien AI|here]].

* [[Wish List#Prior Recon of Battlefield|"Eye in the Sky"]]. Map (set to visible) all terrain features on Turn 1 (but do not sight any hostile units). Ideally this should be only the exterior of buildings but that's probably too tricky. Assume we have something like a FLIR on the Skyranger that can do basic imaging of the inside of buildings.

* Grenades that [[Wish List#Warm Grenades|function normally]].

* Fix Base Storage display problems that lead to storage weirdness. Discussion and recommendations [[Talk:Base Stores#Base Stores Anomalies|here]].

* Enable native alien melee attacks within Alien Pets. The Floaters are pleading. (At the moment, Alien Pets+Big Brother means a crashed Superhuman Floater Large Scout costs 6-8 X-COM agents; corresponding crashed Sectoid Superhuman Large Scout is only worth 3-5 X-COM agents. Floater Large Terror Ship on just Big Brother : only one agent, and that was due to the top-of-stair pinning bug providing enough TU to do something.) -- [[User:Zaimoni|Zaimoni]] 12:39, August 12 2009 (CDT)

* Do something to help out the psi aliens as well within Alien Pets, as above. -- [[User:Zaimoni|Zaimoni]] 12:39, August 12 2009 (CDT)

=== A few more ===

Do any of these take your fancy:

* Draw the Radar detection radii onto the map as a circle(s) around the base (also for moving aircraft?)

* Show All UFOs (Ultrawave Detector - like Show All Locations, but doesn't show Alien Bases, you still have to hunt for those).

* Sensible Ammo Recovery = add up all remaining rounds of ammunition at the end of a mission (in the ship, if Aborting), and recover a number of (full) clips equal to that number divided by the clip capacity (rounded down maybe).
: There's a reason I didn't turn Clip Recovery on, and it's that I guessed that it didn't work exactly as it's suggested here. If it did work like this, I would use it. [[User:Stubbs|Stubbs]]

* Implement tactical time limits for UFO Assaults/Recoveries. After a random period (within a pre-defined upper and lower time limit), the aliens leave. Pop up warnings appear at the end of each turn, saying the UFO engines are powering up. When the aliens leave, all aliens/items/equipment inside the UFO is gone - no loot, no score. Any soldiers still inside the UFO are considered MIA. The soldiers are ''captured'' in fact - score penalty worse than MIA? There must be one conscious alien inside the UFO for it to leave or attempt to leave. Maybe any live aliens outside are 'beamed' or 'tractored' inside the UFO, complete with their equipment? (E.g. the mission ends and you don't get score for them or their equipment either - just for the corpses and dropped loot).

* No Milk Please: After XCom withdraws from an Alien Base, randomise the base's location and make it hidden again. Just like what happens to the aliens after they fail to assault an X-Com base. Though you would probably still need to locate it within the same country or region so finding it again wouldn't take long I guess. Would it mess things up to move the base to a random part of the world?

* [[User:Spike#Tank mods|Tank Armour and Equipment Mods]]

But I should probably code this up myself, looking at your source code it doesn't look '''too''' hard. [[User:Spike|Spike]] 14:46, 24 August 2009 (EDT)

[[User:Spike|Spike]] 14:46, 24 August 2009 (EDT)

=== Multi Stage Missions ===

Between each stage of a multi-stage mission:

* Send all artefacts (non-usable items), corpses and recoverables back to base
* If possible, remember the score for these items, and apply it to the score at the end of the mission
* Alternatively, pop up a score window between the mission stages, and apply the score then?
* Gather all loose usable equipment into the "equipment pile" for the next stage
* Or possibly re-run the Equip Screen between mission stages, again gathering all loose usable items into the equipment pile first.
* Keep an 80 item limit on what you can take into the next stage
* Prune down to the 80 item limit using some sensible rules, not sure what exactly.

This is of limited use in X-Com EU but would be much more use for TFTD, one day. EU has only one multi stage mission, and it ends the game, so only some of these points above will be relevant.

[[User:Spike|Spike]] 20:54, 2 September 2009 (EDT)

=== Even More ===

Tremendous work, you've pretty much made the game worth playing again. Best work since Xcomutil. As with everone else, I have a few requests. [[User:KingMob4313|KingMob4313]] 23:59, 12 August 2009 (EDT)

: Ability to change damage modifier. Right now the damage runs from 0-200% of damage values on the weapon. I'd love to see a way to change it to 50-150%, 75-125% or the like.

: A modifier to increase or decrease the explosion radius modifier. Right now the radius is either keyed to the explosive or to the explosive damage. I'll investigate it further. But it would be nice to have a very small radius, but high powered explosive for use as a breaching charge.
:: There is a "crimping" function on some of the explosions already so it might be possible to exploit that. Check the [[Explosions]] page. [[User:Spike|Spike]] 14:46, 24 August 2009 (EDT)

: A modification of the range based accuracy. One handed weapons have a shorter range, to the point that even their aimed shots have an effective range, two handed weapons have a further range (and no aimed shot effective range) and really heavy two handed weapons have an even further range.

: A modification so that on the alien's side first turn, they do not have their full time units in reserve for reaction fire. Nothing like getting shot 3 times from the same sectiod after missing ONE shot on them.

:: You could always wait a turn before you open the door. :) [[User:Spike|Spike]] 14:46, 24 August 2009 (EDT)

=== More Exploits to Close ===

* [[Exploiting Mind Control#Exponential Mind Control|Exponential Mind Control]]

Probably the worst single exploit in the game. What is needed is to disable any mind control actions for a Psi Amp, if the unit holding the Psi Amp is currently mind controlled.

Also a general mind control bug/exploit fix for:

* [[Exploiting Mind Control#Exponential Mind Control|Civilian Traitors]]
* [[Exploiting Mind Control#Exponential Mind Control|Resurrect Zombified Agents]]
* [[Exploiting Mind Control#Exponential Mind Control|Zombie's Permanent Control of Aliens via Stunning]]
* Probably many other missing/MIA-type bugs

These probably all arise from the daft decision to save a single byte (or even bit), by not recording separately the current vs default "side" a unit is on. The game only tracks the "current side". Consequently when mind control ends, the game often makes dumb decisions as to what side to "restore" the unit to. We could use an unused byte to track the default "side", but that would require overloading a presumed "unused" field and that could be risky. But actually we can always deduce the "default side" from the unit type: XCom for soldiers and tanks, Neutral for Civilians, Alien for everything else. So what is needed is just an end-of-turn check to restore everything to its correct side, based on its unit type. Actually it's slightly complicated by alternating turns. You need to update all (originally) Alien units at the end of the Alien turn, all originally XCom units at the end of the XCom turn. You might also need a special end-of-game update, to avoid the MIA-type bugs. [[User:Spike|Spike]] 12:22, 26 August 2009 (EDT)

: AlienSWP.py implements turnswapping via mind control, like XCOMUtil. Handling the alternating turns, as you described, is necessary to make mind control work properly (a mind-controlled alien remains with X-COM during the alien turn, and so on).

: I would assume that the original programming team had a coding policy forbidding both bitfields, and emulating them with bitwise shifts. That's really the only way I can explain most of the idiosyncrasies of the file format. [[User:Zaimoni|Zaimoni]] 12:07, 26 August 2009 (CDT)

=== See Also ===

*[[Wish List]]
*[[Known Bugs]]
*[[Exploits]]

== Completed Items - Thanks Seb! ==

See also the lists at: [[User:Seb76#Mods]] and [[User:Seb76#Bug_Fixes]]

* Add 1-2 UFO Navigation to the haul after a successful Alien Base Assault.
:The game actually has specific code to remove these from the recovered items, it's just a matter of bypassing it. Next version will have an option to do so. [[User:Seb76|Seb76]] 07:19, 7 September 2008 (PDT)
:: Completed with the "Keep Base Navigation Tables" option.

* Random chance (1-2%, and only for Scouts) per mission that a UFO accidentally crashes - like the "Roswell Incident". Crash site would be automatically detected & UFO would have random damage.
:Sounds like a nice idea. I'm working on it but I still have some crashes, and the routine to check if a ship is over water does not seem to work properly :( [[User:Seb76|Seb76]] 07:19, 7 September 2008 (PDT)
:Update: feature almost complete, time to bake a new version ;-)

:[[Image:Roswell.png]]

:There are probably some bugs lurking (the most likely problem would be unfreed CRAFT.DAT entries), but I don't think I'll change the code much now. [[User:Seb76|Seb76]] 07:47, 13 September 2008 (PDT)

* Got an idea while I was at work today that I thought I'd throw onto the wish list. Some means to completely fast-forward the base defense screen. Either by making all the firing sequences happen in an instant, or completely skip the screen altogether. I always advise against making impenetrable bases if only to preserve your sanity. I mean you eventually get sick of being interrupted to watch the defense module firing screen for the umpteenth time. If you never got the interruptions then an impenetrable base would be quite satisfactory. You shouldn't be getting any points for a failed base attack so you won't be gaining from it. About the only problem would be when an undefended base gets destroyed, unless you can make a dialog box pop up to announce it. -[[User:NKF|NKF]] 03:10, 2 September 2008 (PDT)

: Fixed with "Faster base defence sequence" option. [[User:Spike|Spike]] 06:40, 14 December 2008 (CST)

* Multiple Radar - Fixed.

Can I ask what algorithm you used for Multiple Radar? The algorithm in my BaseFixer.py Python script is actually much better than the fairly lame one described on my User page. [[User:Spike|Spike]]
:As I said, I used about the same as in you BaseFixer script:
float shortDetection=pow(0.9f,smallRadars);
float largeDetection=pow(0.8f,largeRadars);

*(short *)(&base[0x10])=(short)((1.0-shortDetection*largeDetection)*100.0);
*(short *)(&base[0x12])=(short)((1.0-largeDetection)*100.0);
:However I keep the computed value even for the one small/one big radar combo ;-) [[User:Seb76|Seb76]] 07:19, 7 September 2008 (PDT)

* Accuracy reductions for long range snap and auto fire - Fixed.
* Aircraft always ready for mission despite re-fuel/re-arm status - Fixed
* Stack up base build orders in advance - Implemented
* More smoke and fire - Fixed
* Blaster drift and waypoint bug - Fixed
* Stats visible during Equip phase - Implemented
* Melee combat (bludgeoning) with any weapon - Fixed
* With "Council Funding Only", allow items to be sold for money if they are ''purchasable'' (i.e. conventional weapons). Buying and selling these is loss making, and there is no source of them on the Battlescape, so it does not create any "income" (except at the start of the game perhaps). But it does help to manage a tight budget. And you need all the help you can get with "Council Funding Only". Check offset 18 of [[PURCHASE.DAT#Structure|PURCHASE.DAT]] If byte 18 is true then it's ordinarily Purchasable, so it's ok to sell that item. - OK, here is your christmas gift ;-) You can sell what you can purchase now. [[User:Seb76|Seb76]] 08:28, 28 December 2008 (CST)
* Close Down Exploits
** [[ExploitsA#Robotic Manufacturing|Robotic Manufacturing]] / [[ExploitsA#Cybernetic Laboratories|Cybernetic Laboratories]] - Fixed

* More video options. In particular, an option to put padding at the top and the bottom of the screen to preserve the aspect ratio on a 4:3 monitor. Maybe it's just me, but stretching the original height of the game to fit a 4:3 screen makes the Battlescape look weird. (Actually, if you update the source code link, I could try to do it myself. The current source doesn't seem to include your more recent changes. --[[User:Mikawo|Mikawo]] 20:30, 12 August 2009 (EDT))
** Thanks for uploading the new source code. I managed to add the letterboxing that I wanted. If you wanted to make it an official feature I could upload the updated files. And I don't think I said this before, but thanks for the great loader! --[[User:Mikawo|Mikawo]] 18:40, 14 August 2009 (EDT)
:Go ahead and upload/PM me the file (d3d.cpp I presume?), I'll gladly incorporate your modification. [[User:Seb76|Seb76]] 19:14, 14 August 2009 (EDT)

* Fix the [[Tactical Exploits#Fire|bug]] where all units in smoke/fire take stun/fire damage, whenever any smoke/fire hex is hit with an [[Incendiary]].

:: Boy oh boy this is a tough one. First we need to figure out how Incendiary actually works. Zombie is getting in to some heavy testing over on [[Talk:Incendiary]]. Right now, the more we learn, the more we know we ''don't'' know. With this 'Funky Fire' bug, presumably what is going on is that during an Incendiary explosion, the game engine loops through all units that are in fire(and on fire?). This is wrong. What it should be doing is testing to see if they are within the Area of Effect of this particular IN round. The game definitely has working code to correctly select units within an area of effect, since that's what happens for HE and Stun explosions. But in this case it does not apply the correct selection criteria. What is looks like it does is scans the Unitref table (copy in memory) for every unit standing on a tile with fire in it, and maybe also with the 'on fire' flag set. Both of these lookups are actually irrelevant to an exploding IN round. These looks would make exact sense for the end-of-turn processing of fire damage, but not for the instantaneous effect of an IN round. They should use the HE/Stun routine instead, to select the units for processing. Then when the units are selected, it should apply the IN effects - still to be determined. So yes, I think what's happened is the coders mistakenly used the "end of turn" criteria to select units for instantaneous damage/effect when an IN round explodes. Anyway, once Zombie has sorted out the facts, maybe you could take a look at these IN explosion routines? I guess one difficulty is that the HE routine is performing 2 functions - it's doing damage to terrain, and also flagging units to apply damage to. It may also be setting smoke. Similarly, the IN routine ought to have 2 functions - to apply fire/burning time to the tile, but also to apply IN damage effects to the occupants of the tiles. This really could be coded badly and just hard to fix. [[User:Spike|Spike]] 19:17, 11 March 2009 (CDT)

OK I'm pretty sure this is the whole problem with the Funky Smoke/Fire bug. What's going on is the Incendiary Explosion routine is calling the whole end-of-turn smoke/fire processing routine, every time an IN round explodes anywhere on the map. That's why you get smoke induced stun as well as fire-induced damage. All you need to do is find this IN Explosion routine and make it return unconditionally before it calls the end-of-turn routine. That will substantially solve the bug. What the IN Explosion routine ought to do is:

# In area of effect
##add fire to tiles
##'''possibly''' do 33% check for units to catch fire - '''unless''' this is performed by the end of turn routine (probably)
# IF a unit was hit directly
## check to see if it catches fire
## ''possibly'' do "impact" damage.
# Return, '''without''' calling the end-of-turn smoke/fire routine

And it's entirely possible there was never supposed to be any "impact" damage, all that was intended was to set tiles and units on fire, with any damage only coming at the end of turn. You can easily imagine a last minute and ill-considered coding decision to run the end of turn routine upon every IN explosion, as an attempt to increase IN lethality, without thinking through the implications properly. So the "impact" damage could just be a side effect of the funky fire bug - applying the 5-10 "on fire" damage right away, when it was meant to be applied at end-of-turn.

[[User:Spike|Spike]] 22:11, 11 March 2009 (CDT)
:Hey, that's a nice piece of supposition:) There is actually what I called an ApplyFireAndStunDamage function which is indeed called after IN explosions and at the end of the turn... It basically damages/stuns every unit on fire/in smoke and makes units standing in firing tiles possibly take fire. The function is called 5 times, one of which is at the end of the turn so patching the 4 other locations should remove the bug; but also weaken the IN rounds...[[User:Seb76|Seb76]] 16:22, 12 March 2009 (CDT)

::Thanks! :) But now you're scaring me - why would there be '''4''' calls to this function, apart from end-of-turn? Why wouldn't there just be one piece of common code, one call, for IN explosions? I'm racking my brains. I guess there could just be 4 different situations when an IN round could explode. Maybe - direct impact, impact with terrain, reaction fire, large units, auto fire... guesswork! Reaction fire is a good guess - we already know lots of things that are bugged with reaction fire, which suggests the code for reaction fire may be a separate loop. There are hints that auto fire may be handled differently for IN - only hints. I'd be worried patching out all 4 calls. But, if you can do it, I'm very happy to test for unintended consequences.

::It will be interesting to see if patching out all 4 calls eliminates "impact" IN damage from direct hits - suggesting it was only ever an unintended effect of the bug. It may not be possible, but "impact" damage might be the one thing to retain, to avoid making IN weapons too weak. Still it might not be an option. Interesting stuff!

::Any chance you could do 5 separate config file flags to mask out the 5 calls? Then I could determine by experiment what each one does. [[User:Spike|Spike]] 18:27, 12 March 2009 (CDT)

* Replace the batch file that runs xcomutil. Make it so the loader will call an outside program at certian points. Add a section to the config file that will allow the user to pick a program to be run.
[Utilities]
Run Utilities=0|1
Run before battle="xcomutil ..."
Run after battle ="xcomutil ..."
Run before base screen="xcomutil ..."
:The above works perfectly. [[User:KingMob4313|KingMob4313]] 00:05, 13 August 2009 (EDT)

* Allow scrolling the map with the keyboard. "WASD" as default maybe, since you used the arrow keys and most people have thier left hand free anyway. Allow moving units one square at a time with the numpad. First tap changes facing if not looking that way, second one moves you in that direction.
:Fixed via Keyboard Shortcuts - and configurable too.

== Warm Grenades ==

It would be nice to have a Mod where grenades / HE explode a set number of half-turns after you drop/place them.

This could be implemented by an extra bit of logic that increments the "Turn When I Will Explode" field by +2 if the grenade is being held/worn when the Explode check happens.

For me this is a more natural way for grenades to work: set the fuse, then the fuse only starts when you release the spring or set the HE pack in position. Certainly hand grenades should behave this way. I guess people could argue that HE packs should behave in the standard way. In which case, you could check the weapon type and use different logic for HE.

Hopefully the Alien AI would not be confused by any of these changes. I suspect the AI cheats anyway? Or always sets to 0 and throws right away? [[User:Spike|Spike]] 02:00, 2 September 2008 (PDT)

== Facility maintenance cost bug ==

Could you fix that? [[User:Spike|Spike]] 16:15, 3 September 2008 (PDT)
:I'm a bit confused about this one. Some says that the fund graph is OK but not the amount of money taken. I had a look at the code and found that what is shown on the graphs is exactly the same amount as removed (the graph data is updated at the same place and the computation is done once for both). I think I remember also someone saying that the bug does not exist at all... Can someone clarify? [[User:Seb76|Seb76]] 02:31, 15 September 2008 (PDT)
::The graph is ok and the amount of money taken is ok (tested). What is wrong is the maintenance displayed in the 'Base overview' screen (in every respective base you go to 'overview' and something like 'maintenance'). The wrong way is very well described here [[Base_Facilities#Displayed_Base_Maintenance_Cost_Bug]], I think you will guess what exactly is wrong in the code. --[[User:Kyrub|Kyrub]] 15:34, 17 September 2008 (PDT)
:Thanks, I found the code and it is indeed completely f*cked up. I'll try a fix tomorrow. [[User:Seb76|Seb76]] 16:53, 17 September 2008 (PDT)
:Edit: Done. What's next? ;-) [[User:Seb76|Seb76]] 01:15, 18 September 2008 (PDT)
::Blimey. Seeing the work you have put in (below), it is impressive beyond measure. And... what next? Well... Could you possibly fix a game harming BUG of the blind spots? How come he sees you, and you do not see him, and vice-versa? There must be some strange way the line of sight is implemented in the code... See here: [[http://www.ufopaedia.org/index.php?title=Line_of_sight]], "Blind spots around the corner".
Just how bad was the mess up? Curios minds demand to know! By the way, my mind was wandering while at the office and one thing came to mind to add to your already useful inventory display: Armed grenade status. Ever drop one you've just armed and lose it in a pile of other unarmed grenades on the ground?
:Well, from the look of it, I think they were trying to compute the maintenance cost using an array. Obviously something was wrong.
:*they first try to clear an array of 0x11 entries at the begining of the function (there are 0x11 base elements types, hangar count as 1). Note that there is already a bug here and the array is not cleared as expected, only the first entry is cleared 0x11 times...
mov esi, 11h
...
loc_44004C:
dec esi
mov word ptr [esp+3Ch+elementsArray], 0
jnz short loc_44004C
:*ecx is initialized to point to the maintenance cost data (nothing wrong here)
mov ecx, offset baseElements.maintenance
:*then they loop on each base element, but the inner loop is nonsense (at this point ax contains the base element type. edi is the total maintenance cost):
movsx eax, ax
inc word ptr [esp+eax*2+44h+elementsArray] ;increment the array entry corresponding to the base element type
lea eax, [esp+eax*2+44h+elementsArray] ;get the address of the array entry we just incremented
xor eax, eax ;discard the address we just computed (!)
mov al, [ecx] ;get the maintenance cost from ecx; the element type is not used here (!)
lea eax, [eax+eax*4]
lea eax, [eax+eax*4]
lea eax, [eax+eax*4]
lea edi, [edi+eax*8] ;totalMaintenaceCost+=elementMaintenanceCost*1000
:we see that they increment the array element, but the content of the array is discarded and the maintenance cost (edi) is computed simply from [ecx].
:*then after each row, we have this:
add ecx, 10h
:which explains why the cost changes for each row.
:I don't see what kind of C code could produce such disassembly; maybe there is a bug in the compiler,at least the address calculation should have been removed (optimized out).
:The fix required two patches:
:*remove the incrementing of ecx for each row
char nop[]={0x90,0x90,0x90};
PatchInPlace(0x44066E,nop,3);
:*make a working inner loop:
char patch[]={
0x03, 0xc0, // add eax,eax
0x8a, 0x04, 0xc1, // mov al, BYTE PTR [ecx+eax*8] ;get the maintenance cost for the *specific* base element
0x0f, 0xb6, 0xc0, // movzx eax, al
0x90, 0x90, 0x90, 0x90, 0x90 // nop the remaining
};
PatchInPlace(0x440651,patch,13);
:this takes care of the nonsense code
inc word ptr [esp+eax*2+44h+elementsArray] ;increment the array entry corresponding to the base element type
lea eax, [esp+eax*2+44h+elementsArray] ;get the address of the array entry we just incremented
xor eax, eax ;discard the address we just computed (!)
mov al, [ecx] ;get the maintenance cost from ecx; the element type is not used here (!)

Very interesting stuff! By the way I'm playing a "Roswell" game at the moment and loving it - thanks Seb! [[User:Spike|Spike]] 10:31, 20 September 2008 (PDT)

==Grenade Status Indicator==

Is it possible to include an indicator on the end of the grenade's name string to show whether the grenade has been armed? Or perhaps even show how many grenade ticks are left to go?
:Hmm, I'll see if I can find something

== Keyboard Support ==

Would it be possible to introduce some keyboard shortcuts for simple tasks? -[[User:NKF|NKF]] 00:48, 19 September 2008 (PDT)
:sSuch as? [[User:Seb76|Seb76]] 02:52, 19 September 2008 (PDT)

:: Hmm, perhaps a few keys like they had in Apocalypse for ending the turn and raising/lowering the elevation with the page up and down keys would be a good start, or jumping to the inventory screen. Perhaps keys in the Geoscape for setting the time compression settings. I can already see a bit of an obstacle with adding a key capture function in the Geoscape, you'd have to know when you're entering strings or every other time when you're just toggling the Geoscape overlay. I've always admired this game for relying on a two button mouse for pretty much everything except when entering strings, but if it's within the realm of possibility I think it would be great to have some keyboard shortcuts. -[[User:NKF|NKF]] 12:39, 19 September 2008 (PDT)

Well, since it has been a little while now, and nobody has said anything, let me be the first. Thank you for the shortcuts on the geoscape. As I mentioned before, I had the shortcuts on battlescape on, but personally I never used them because it is not timed. But the geoscape, being that there is no pause, I have found a lot of use in shortcuts. Works perfectly for me, too. Secondly, the obdata editing feature is fantastic. If only it worked on accuracy, too....
Thanks again, my friend. --[[User:Talon81|Talon81]] 17:19, 22 May 2009 (EDT)
:I've put a new version with support for more settings, give it a shot ;-) [[User:Seb76|Seb76]] 06:25, 23 May 2009 (EDT)

----

First off have to say that this is outstanding work Seb, sincere thanks for what you have done here. I have started playing this again after years thanks to your hard work. I was going to suggest the old smoke limit problem but before I could you fixed it!! I have some other ideas, I know there are a lot but I thought I would throw them in anyway. Don’t mind if you think there all rubbish, you’ve done loads already.
:Thanks. Don't hesitate to suggest stuff, if it is not too difficult I'll try to make something :)
BTW is there a separate loader with your new Laser weapon? Can’t see it listed in the extender file (not researched it in my current game yet).
:There is a special [[Image:UFOExtender-dev.zip|dev version]] for the HL mod. It is not in the normal package since it is still too experimental.
A suggestion for a mod would be the following; I understand that if you defeat an alien assault on your base with base defense measures, then the aliens will continue to attack that base with more battleships until defeated inside the base (they then have to ‘find’ your base again before launching another attack). Can this be altered so that if their battleship is destroyed then they have to find your base again before dispatching anther battleship? Or a chance that they have to find it again.
:I'd gladly work on that, but I need a savegame to reproduce the problem. I have one but when the battleship is destroyed, no other comes back later so there must be something wrong with it.
Another suggestion is that I also understand that when the aliens use psi attacks they always go for your guys with the most chance of failing the attack and going nuts. Is it possible to make those pesky aliens attack random soldiers, regardless of their psi skill/strength?
:At one time I had the idea of having aliens target only visible units, but then I thought that the scout units would be doomed. Maybe targeting any unit randomly would be better. I'll give it a try.
If you psi control a human in a terror mission, they become enemies when you lose control (meaning you have to kill the poor idiots to finish the mission). Any chance that they could revert to friendlies/non enemies again when you lose control?

Men who are under alien control when you win become MIA, any chance they could be saved (you will have killed all the aliens after all).
:These two are on my secret todo list ;-)
::I was doing a Terror mission and getting creamed by Sectoids and Cyberdisks. Had a couple of guys left and got them back into the Skyranger only to find a civilian cowering at the back (must of walked in at some point). When I took off the civilian was counted as being killed by the aliens. Would it be possible to count any civilians in x-com craft at end of Terror as recued if you have to blast off? I think this would work interestingly with the civilians psi control issue above if they no longer became enemies after you control them. :-)--[[User:Mal310|Mal310]] 09:23, 22 September 2008 (PDT)
80 item bug on base defense mission
:May be hard to pull off. IIRC there is a 170 objects limit in the battlescape, and we must leave some room for the aliens...
I have noticed that sometimes you can shoot through hard objects, for example, recently I had a soldier up on the roof of a house overlooking a large scout craft. When a Sectiod moved through one of the inner doors of the UFO, my man shot him straight through the intact ufo roof!
:I think this is a known issue with LOS, not sure though
I don’t know if this is already implemented in the game? When the aliens attack your base and you defend it with base defense measures does the following occur and if not a mod maybe? When you hit the battleship with your weapons but it still gets through (e.g. you hit the battleship with some missiles before it lands) can the number of attackers be reduced accordingly. For example if you hit it with some missiles then maybe they could have a couple less soldiers attacking (could be random small amount) or when you hit with loads of stuff like plenty of fusion balls and the battleship just makes it then their attack could be reduced to a few aliens (all others got killed in the defense). As I say not sure if this is already there to some degree (not played in a long time and I’m not at that stage yet this time round).
:I don't think this is done already. It may be possible to modify the number of units according to the damage done to the attacking ship, I'll have to take a look
This one is way out there. Alien v Alien battles outwith main game, just ramdom battlescape maps. Sectoid and their terrorists against Floters and theirs etc. One side human controlled the other computer . Choice of ships involved etc.
:Hmm, you do know I don't have the original source code available, don't you? :p
Any plans to work on Terror from the deep?
:I had a look and reidentifying the specific patch locations is quite tedious, and I'm quite lazy... The loader source is available however, if anyone feels like giving it a shot ;-) [[User:Seb76|Seb76]] 16:38, 19 September 2008 (PDT)

Thanks for the reply. If I get a suitable saved game re the base attack I’ll let you know. Great to hear that a couple of the ideas are on your list already. I have been playing around with the smoke bombs since your fix. I have not noticed any problems, seems to be working fine. --[[User:Mal310|Mal310]] 12:10, 21 September 2008 (PDT)

== Inventory screen ammo weight bug ==

I think there is a small bug. The weight of loaded weapons is not initially calculated. The base weight of the weapon is used but the weight of the ammunition is ignored. However if you reload the weapon in the inventory screen, the correct weight is then calculated. I have seen this repeatedly with AutoCannons. I am using XcomUtil to 'remember' the equipment loads - maybe this might be part of the problem? [[User:Spike|Spike]] 09:24, 21 September 2008 (PDT)
:Yeah, I noticed this one already but flagged it as minor :) I'm using a function that I found in the executable to calculate the weight (the one that's actually used by the game to see if a soldier is overburdened) so it is an original bug. Anyway, this calls for a fix ;-) [[User:Seb76|Seb76]] 09:47, 21 September 2008 (PDT)

:: Is this the same bug that is present when calculating the throwing range of a loaded weapon? (NKF)
:Does not ring any bell. Any link?

== Equipment issue ==
Also, something that I was reminded of while in the rifle vs. laser pistol discussion. It's not related to the weight bug but it is inventory related: The weird pistol arming bug where sometimes no one arms any pistols, or only one guy will arm one pistol and then fill every available inventory slot with the respective pistol clip. I'm sure it was thrown in so that pistols were always the last to be armed, but is it possible to make the game ignore this and arm the pistol like every other weapon? -[[User:NKF|NKF]] 15:20, 26 September 2008 (PDT)
:There is a lot of possible work to do with how the soldiers are equiped (equip stuff on shoulders first instead of belt, keep equipment from last battle à la xcomutil, stop having one guy get stuffed up with every ammo available, etc). Since obviously all that is tightly intertwined, it requires some thought before getting into it... Plus this is a part of code that I did not analyse yet ;-) [[User:Seb76|Seb76]] 03:40, 27 September 2008 (PDT)

== Request For UFO PS Explosion Offset ==

Hi Seb, in the [[Talk:Explosions#UFO_Power_Source_Explosions|Explosions Talk page]] you mention the following:

Looks like before the first turn, the engine will look for every tile in the map (it scans the MAP.DAT data linearly) ; when it finds a power source (it checks if the MCD special property is set to 2), there is a 25% chance that it will leave it alone. Otherwise, it'll generate an explosion at the UPS location with a strength of 180+RND*70. Whether the UPS blows up on top of that or is just destroyed, I do not know. Can someone hack the MCD data and see if it's possible to generate an explosion on a tile that is not a UPS just by messing with the special property? PS: I am almost certain of the 75% probability of explosion vs 70% that is often stated here. [[User:Seb76|Seb76]] 09:31, 12 February 2008 (PST)

I'm just wondering where the power source explosion is coded in the executable. If you could tell me that, I'd be able to edit it down so that units don't take quite so much damage. This is a whole heck of a lot better than editing unit stats to near maxed-out levels as the number of trials needed to find the average would be cut by a few orders of magnitude. Also, if you have an email address where I could contact you directly, it would be appreciated (email me with it). Thanks! --[[User:Zombie|Zombie]] 23:58, 2 November 2008 (CST)

== Great new features ==

Hi Seb! I just saw you uploaded a version with lots of new features. It was a great idea to add some of the [[Making the Game Harder]] scenarios. I look forward to trying all the new features out (some previous ones I've missed as well). Cheers! [[User:Spike|Spike]] 16:37, 19 November 2008 (CST)

:OK I dusted off my Windows version of XCOM and installed your latest loader. I have to say I love it! The range-based accuracy is great. I use about half the default values, I might try returning them to the default levels as it makes snap>auto for everything above point blank. But it's definitely working as designed. And I love the %Acc indicators over the target square. Not to mention the (primed) indicator on grenades.

:I played with Alien Pets and Big Brother and View All Locations and found a few strange bugs:
:* If you use the left and right arrows in the Inventory screen to try to move to a different Alien unit, you only see human units
:* The character graphic displayed on the Inventory screen is a human, not the appropriate type of Alien
:* For some reason if you check on turn one the aliens weapons are not loaded and not in their hands. This was in a Roswell scenario, so might be more to do with Roswell. - No, I also got it on my base defence mission. Hang on, silly me, this is just normal for Aliens under mind control isn't it?
:* In night missions, even with Big Brother <strike>and View All Locations</strike> set, I could only see what my guys had illuminated & seen.
:* View All Locations showed the incoming Battleship before my radars detected it on the half-hour, which gave me a brief chance to prepare my base for attack. Not exactly a bug, more a feature - different. Sadly I wasn't quick enough so ended up defending with loads of ammo clips and not enough weapons. :)
::The "Hack" section is really not to be used for gameplay; there I put patches that are useful to test my stuff, nothing more. I only make them available in case it can help someone with her analyse of the game. All the strange things you mention are expected behaviors ;-) [[User:Seb76|Seb76]]
:* With Alien Bases and View All Locations, the X-COM bases show up as pink.
:* It wasn't obvious to me that I needed to set e.g. "Initial Alien Bases=20" rather than just "Initial Alien Bases=1". I is dumb! [[User:Spike|Spike]] 17:20, 25 November 2008 (CST)

:Now I need to check the notes on this page to get it working with XComUtil. The one thing that really p____s me off about playing without XComUtil is having to allocate equipment to my guys before every mission. It's really tedious! Especially as I tend to take 14 guys on each mission.
:I have not developed Heavy Laser yet, <strike>nor beaten up any aliens in melee,</strike> but I will let you know how that goes. Thanks for all your amazing work! [[User:Spike|Spike]] 19:00, 23 November 2008 (CST)

:: Awesome. I just completed a mission by my Captain pistol-whipping a Floater Navigator into unconsciousness. How cool is that? But - possible bug - it cost my guy only 8 TUs per attack when he has about 58 total TUs. Is that intended, or is that an error? [[User:Spike|Spike]] 19:38, 23 November 2008 (CST) ''(Later)'' I'm regularly beating up aliens, it's a giggle. The close quarters combat feels much more authentic now, I love it.
:::The small TU usage for the pistol is normal (it goes with small stun damage). I liked the idea of having to bash an alien for a while before he falls. Did you not experience reaction fire from the alien? [[User:Seb76|Seb76]]
::::The TU costs are percentage based instead of fixed(this has been clarified on the main page). 15% of 58 is 8.7 TUs, which truncates to 8. [[User:Arrow Quivershaft|Arrow Quivershaft]] 14:15, 24 November 2008 (CST)
: I'm having so much fun and doing so well I got a Base Defence on Superhuman on Jan 12th. And with the old, sucky starting base layout (hangars take 25 days to move!). I've never seen so many Floaters and Reapers at one time. I knew there was a reason to hang on to those Incendiary rounds - bad doggie, down! Loads of fun, however one or two bugs have cropped up:
::Glad you're having fun :-) [[User:Seb76|Seb76]]

::* The game crashed as a soldier walked down the stairs from Living Quarters. This is probably a bug in the game and not a bug in your loader.
: Let me know what details I can give you. [[User:Spike|Spike]] 20:43, 23 November 2008 (CST)
::Can you provide me with a savegame that reproduces the crash? I think it is the bug that makes defence missions crash around turn 5-6 sometimes (it crashes during the alien turn). I could not reproduce it. [[User:Seb76|Seb76]]

== Base Disjoint Bug Fix ==
A Base Disjoint has occurred, despite enabling your Based Disjoint bug fix. <strike>It may be an usual one because it's not on the bottom nor the right edge of the map (isn't that where Disjoints are supposed to happen?)</strike>. It's the normal, bottom of the map edge kind. Here is a [[Media:BaseDisjointGenStores.ZIP|screenshot]] (anyone got a freeware TGA converter?).
: Hum, the code was badly f***ed up. Can you retry with the last version? [[User:Seb76|Seb76]]

I downloaded the latest version but unfortunately no effect. It didn't fix the saved Base Defence scenario. I also restarted from 3 hours before the attack and so created a new Base Defence mission, twice, but no change - still bugged. I'll post the [[Media:IncomingRetaliation.zip|savegame from 3 hrs before]] in case that helps. [[User:Spike|Spike]] 14:24, 25 November 2008 (CST)
:Kinda weird, it works here. Maybe I made a faulty delivery... [[User:Seb76|Seb76]] 15:34, 25 November 2008 (CST)
:Edit: nope, took the patcher from the delivery and it worked. Are you sure you enabled the fix? [[User:Seb76|Seb76]]
Yes I doubled checked a couple of times. I set the flag as

Base Disjoint=1

Is that correct? I'll try again anyway. [[User:Spike|Spike]] 17:20, 25 November 2008 (CST)
: Oops my fault. I updated the .exe but not the patcher.dll. (I didn't want to overwrite my UFOExtender.ini - very lazy of me.) Doh!

== A couple of bugs to report ==

Two things so far. With wreck analysis enabled I am getting analysis reports even after raiding alien bases. On one occasion this seemed to have fairly random strings inserted into the variables, resulting in the message "The Alien Food UFO was on an Damage Capacity mission in Power Sources." All things considered, this is just a cosmetic problem as the actual UFOs are being properly analysed. However, this has got me curious as to what enables you to perform these analyses? It doesn't happen right from the beginning of the game, at least for me. From the description of the feature I thought maybe it was after researching UFO navigation, but then the messages started popping up before that.

The other bug I have encountered is more severe. After building my first Firestorm I was completely unable to send it out for interception. Clicking on the craft in the list simply returned me to the Geoscape screen without allowing to pick a target, and the game continued to play normally. Disabling the feature for crafts to always be ready despite rearming, repairs and refueling fixed this. [[User:Crowley|Crowley]] 15:52, 3 January 2009 (CST)
:Been out for a while... I'll have a look at these two. [[User:Seb76|Seb76]] 11:04, 2 January 2009 (CST)

Another case of erroneous wreck analysis, this time from an actual UFO: I followed a battleship on an alien base mission and assaulted it when it landed on its own. After the battle the analysis claimed it was on a raiding mission. Perhaps this has something to do with how alien bases are created the moment the battleship appears? [[User:Crowley|Crowley]] 15:52, 3 January 2009 (CST)

:I use the data from [[MISDATA.DAT]] to get the mission details. Perhaps it is not correctly set at the time I retrieve the information. I'll investigate further. As for the firestorm problem, do you have a savegame just before the craft is finished so I can reproduce the bug easily? [[User:Seb76|Seb76]] 18:23, 3 January 2009 (CST)

::Unfortunately not, but I did make a separate save shortly after the craft was finished. I tested it, and turning on the "crafts always ready" option still disables Firestorms with all my saves. With more testing I found out this also affects Lightnings, but not Avengers. [[User:Crowley|Crowley]] 08:36, 4 January 2009 (CST)

Instead of MISDATA.DAT, maybe grabbing the first byte out of [[LOC.DAT]] might be more accurate? I'm not entirely positive if offset 76 of MISDATA is for just crash sites or all sites in general. BB would know for sure. --[[User:Zombie|Zombie]] 20:25, 3 January 2009 (CST)

:"Raiding" ''is'' what you're supposed to get if you're not lucky enough to get both the mission type ''and'' the zone, as in the .ini file: <pre>Zone Discovered=Intel found out that the %s UFO was raiding %s</pre>If I remember correctly, difficulty level and the number of recovered navigation modules determine the chance of finding out both pieces of information, so it can't be Christmas every day ;)

:Regarding the 'Craft always ready' option, I had some Interceptors not launching as described by Crowley above but turned out they had 0% fuel, thanks to the [[Known_Bugs#Fuel_dump_on_transfer|transfer bug]] (shuffled them around ages ago to make room for Avengers and forgot about them ;) ). Maybe Crowley's Firestorms were also transferred around? In any case enabling this option is a bit tricky, if you happen to have craft with the fuel bug sitting around without realising it (or knowing about the bug to begin with); all I can think of right now is to have this option enforce the transfer bug fix ''and'' somehow have buggy craft (0% fuel but ready) update their status to 'refuelling'... Wouldn't be surprised if there's a global 'update interval' in Geoscape when all craft marked as 'refuelling' get their fuel level increased; if so, it might be possible to change that status check to use fuel level instead (much like what this option already does, for the selected craft only) [[User:Goran|Goran]] 00:09, 4 January 2009 (CST)

::Repairing interception craft repair one point of damage capacity per hour (XX:00), refuelling interception craft are granted an amount of fuel each half hour(XX:00 and XX:30) dependent on craft, and rearming interception craft are given an amount of ammo each hour(XX:00) dependent on the weapon being loaded. [[User:Arrow Quivershaft|Arrow Quivershaft]] 05:12, 11 January 2009 (CST)
:Being busy with work ccurrently so I've not much time for the loader. I already use the fuel level instead of the status. I used a value of 30 as a threshold for readyness which is OK for standard fuel ships, but for elerium ships it's too high: even when fully refuelled, they don't exceed it. Reducing the value should be enough to fix the problem. [[User:Seb76|Seb76]] 05:22, 11 January 2009 (CST)

Some more comments:
# Limited Military = 1 gives you only 1 soldier. OK, I guess it's meant to do that, but it was not obvious. User error! But maybe it's time to add "usage" comments to the .INI file?
# Personnel Overflow works ok, even when the extra personnel are transferred in from another base (instead of being Recruited) - good job!
[[User:Spike|Spike]] 13:20, 2 January 2009 (CST)
:What's wrong with the info from readme.txt? [[User:Seb76|Seb76]] 05:13, 3 January 2009 (CST)
*Limited Military: you start with this specified amount of soldiers and cannot recruit any more during the game

:: User Error ^2 - I didn't read the readme.txt either :) [[User:Spike|Spike]] 12:17, 3 January 2009 (CST)

Errr.... why do Launchers do more stun damage than the Stun Rod? ... Electrocuting someone should do more than just hitting them with a large object? ... for that matter, stun damage of 80 is a LOT... remember that being shot with a rifle does 30, and a grenade does 50. (IMHO, the stun rod is likely to use VERY high voltage... it is much larger than a normal stun gun, and X-com doesn't mind doing permanent damage to the aliens)
Here's a challenge for your coding skills, and a logical one too: make melee do more damage based on Strength stat. My 80 strength goliath should do more damage than my 10 strength rookie wimp... [[User:Jasonred|Jasonred]] [[User:Jasonred|Jasonred]] 18:40, 26 February 2009 (CST)

== Glitches with Alien Pets ==

OK I know that Alien Pets is a Hack and we should expect side effects. I just want to list them here for information purposes - please do not feel under any obligation to fix them!

* If Alien Pets is set to 1 at the start of a Battlescape mission, Aliens generate with all their equipment in slot 2, i.e. no clips in weapon, no weapon in hand. They remain in this state until they spot a human in their own turn, at which point they lose 19 TUs drawing and loading the weapon. Furthermore, they are incapable of reaction fire until they have seen a human, drawn and loaded their weapon as a result, and survived the experience. From [[Talk:Alien Inventory Use|discussions]] it seems likely that there is a pre-battle routine which moves a weapon from slot 2 on each alien, and arms it, prior to the start of Battlescape turn 1. This routine bypassed - possibly because Alien Pets flags the alien units as human-controlled, and so this 'arming' routine ignores those units?
* It is possible to get to an Inventory screen for large terror units. Normally this is blocked (even when using the Alien Inventory 'trick'). This has these effects:
** Large terror units can pick up and drop items. To pick up, position the topmost/northwest corner of the unit over the item. The Cyberdisc makes a great cargo vehicle!
** Terror units can also equip weapons in their "hands". Move the weapon to the left hand slot and it will appear in the Battlescape display. However the weapon can't actually be used. Using the left weapon will cause the unit's built-in ranged weapon to be used instead. (But test with Reapers or when the built-in is out of ammo?)
* I also saw some very weird TU and Weight/Encumbrance behaviour. Aliens at 200% encumbrance, unable to do anything and losing TUs each round. I need to characterise this more clearly.

This might or might not be unrelated (might be due to me using Bomb Bloke's object editor wrongly):

* When an Alien loads a clip into a weapon and fired it, the ammo count goes negative. This clip (or even single rocket/bomb) then becomes an infinite ammo supply. Probably a signed vs unsigned integer error?

Now regardless of all these minor points, Alien Pets has been very helpful for me doing research on the Alien AI and Inventory handling, so thanks very much for this useful hack!

[[User:Spike|Spike]] 19:04, 5 March 2009 (CST)
:My pleasure. It was the very reason I allowed it in the loader in the first place!
:FYI: the weapons are not handed in a hidden turn but while the aliens are spawned. Also I think reaction fire is completely disabled for the aliens when the hack is activated [[User:Seb76|Seb76]] 13:37, 6 March 2009 (CST)

:: Alien reaction fire works fine for me within Alien Pets. -- [[User:Zaimoni|Zaimoni]] 12:41, August 12 2009 (CDT)

I dropped by after three months or so (you've inspired me to start an disassembly work on another oldie strategy ->> no time), and I am really astonished, Seb. Behold, incredible work with one of my old wishes, the decreasing accuracy. Fantastic for the gameplay!
So - ehm - I'll try to wish for one more, hope you do not mind. There is the last, very (game-wise) frustrating issue: the AI fires a weapon and then sidesteps the alien just out of your view. I am bored to death to make that one step forward and always find the bad guy and shoot him in the back. If you could make this "retreating" a somewhat random thing (random APs, random where to), it would thicken the atmosphere (where he is??) and make the game 10x better. I guess you can't make them 'search cover', but make them running away RANDOMLY will do the job for me. I'll be very thankful to you. --[[User:Kyrub|Kyrub]] 20:26, 1 April 2009 (EDT)
:Thanks for the support, I'm bored of the "the stuff does not work with ET" thing ;-) I can have a look but the alien AI is one of the points I'm clueless about, I don't really know what to look for. When I study the parts that interact with ROUTE.DAT data, I cannot figure what the hell is going on... Do you know if the backing alien has ran out of TUs? Maybe the game tries to keep some for reaction fire but no-one realized that turning your back on danger is not the best tactic for reaction shots ^_^ [[User:Seb76|Seb76]] 15:46, 2 April 2009 (EDT)
::The situation happens always a) in the open b) during the alien turn c) when the enemy spots you, fires and then retreats out of view. I think he even turns back to face you sometimes, but not sure. But the main (gameplay) problem is that you are totally safe to advance 1 step and shoot because you have full TUs, no reaction fire, no support from other aliens. Perhaps the program determines the quadrant with human, via substracting the positions and finding the angle with a pre-made table in the exe (I have the same thing in my disassembling game)? Or it just loops next fields until it finds the one without eye-contact? -- I am almost sure that this was repaired in the Ufo Tftd. The aliens are very nasty and retreat totally out of view... -- BTW, the aliens do well in the vessels in UFO-eu, they search cover in the next room!--[[User:Kyrub|Kyrub]] 16:22, 2 April 2009 (EDT)
:Hum, too bad I never got to disassemble TFTD then ;-) BTW, which game do you work on? [[User:Seb76|Seb76]] 17:22, 2 April 2009 (EDT)
::Master of Orion I, correcting the bugs and improving AI. (Hey, noticed the doors' thing. Another great one.) --[[User:Kyrub|Kyrub]] 20:09, 2 April 2009 (EDT)

== TFTD Door problem ==

Seb, there seems to be a problem using the TFTD Doors with the Proximity Mine bug fix. I do have several other patches to my game, and it is possible that they are complicating the matter, but simply by turning off the PM fix I can suddenly open doors again. --[[User:Talon81|Talon81]] 06:02, 14 April 2009 (EDT)
:Hi Talon81, what do you mean by "other patches". Are you using ET or xcomutils? Or are you just enabling other patches from the loader? Also what are the symptoms exactly. Can't you open any door? [[User:Seb76|Seb76]] 14:24, 6 April 2009 (EDT)
:Edit: Nevermind, I could reproduce the problem. Can you try the new version I just uploaded? [[User:Seb76|Seb76]] 15:08, 6 April 2009 (EDT)

Yeah, I tried it, and it works fine. As you no doubt have already figured out, it wasnt working on any kind of door, as far as I could determine. The other things I am using should not interfere. They are minor patches such as Zombie's combo patch for terrain, etc, CE to DOS sound editor, and the aimed accuracy adjustment patch. I am not using Xcomutil or ET (would like to use ET, but I know that it doesnt work well with your patch).

If it means anything to you, I would like to say that your work has meant a LOT towards making this game what it should have been. I fell in love with this game in 94, and never have more than a couple years gone by without me playing it. Your patch is the best thing to come along since it was made. ;-)
--[[User:Talon81|Talon81]] 06:02, 14 April 2009 (EDT)

: I second that, wholeheartedly. [[User:Spike|Spike]] 16:44, 14 April 2009 (EDT)

:Thanks guys! This game is the best and I try not to divert it from its spirit with my patches... Actually the fix for the doors *might* increase compatibility with ET, but it's a wild guess. [[User:Seb76|Seb76]] 16:56, 18 April 2009 (EDT)

== Initial Alien Bases ==

OK, so I was having some problems getting alien bases to work, so I created a new folder of X-Com with nothing but your video patch on, and alien bases. I am still having the same problems I was having on my more heavily patched version. For example, I created one with 3 alien bases. Looks fine. I run it with the show all locations patch and sure enough, no alien bases. I make a new game with the show all patch on and there are the alien bases, shown until the point that I place my own base. Then they disappear and my base now looks like an alien base. There are some other minor bugs associated, too; however, that seems to be the main problem. In short, I have yet to get an alien base to survive past the placement of my base. I thought it could be a glitch in the show all patch, but scouting the areas where the alien bases were shown prior to base placement has returned nothing. --[[User:Talon81|Talon81]] 15:23, 19 April 2009 (EDT)

By the way, Seb, are you the same as Strife67? --[[User:Talon81|Talon81]] 13:13, 24 April 2009 (EDT)
:Nope, never heard of that guy. What's he doing? [[User:Seb76|Seb76]] 15:13, 24 April 2009 (EDT)

Nothing anymore. He created a sound patch a year ago or so, and there were some things he said that reminded me of you, not to mention in my head I was thinking you were Seb67 instead of Seb76. I just now noticed my mistake. --[[User:Talon81|Talon81]] 20:16, 24 April 2009 (EDT)

:OK, I uploaded a new version. Can you confirm it fixes the problem on your rig? [[User:Seb76|Seb76]] 07:57, 26 April 2009 (EDT)

Seems to have solved the problem to me. The alien bases now appear after placement of mine instead of before like they previously did. X-Com bases are correctly shown, as well. --[[User:Talon81|Talon81]] 13:34, 28 April 2009 (EDT)

== Won't work on my rig Vista+CE version ==

Nice work! I really want to play this, it's not working on my PC though. I may be stuck with the Dos version in Dosbox forever.

My screen flashes between the squashed look of the unpatched EXE and the OK version. On screens without animation it changes back and forth as I move the mouse. On the Geoscape it just flashes and gives me a headache. Sorry about the big images, to lazy to cut them down.

* http://darksun.lunarpages.com/XCOM/Scrambled%20P1010264.JPG
* http://darksun.lunarpages.com/XCOM/Fine%20P1010265.JPG
--[[User:SaintD|SaintD]] 19:09, 19 April 2009 (EDT)
:Hum, looks like another Vista problem... Do you have the problem when using [http://appaholic.co.uk/2007/10/16/dxwnd-force-almost-anything-into-a-windowed-mode/ DXWnd]? I use the following settings (but I'm under XP...):

[[Image:Dxwnd.png]]

[[User:Seb76|Seb76]] 14:57, 20 April 2009 (EDT)

Awesome. That worked. My 1440x900 regular resolution means that the window is really tiny though. You should really get the upscaler working now. Heheh. Dxwnd makes Internet Explorer crash on vista. Does that happen to you?

http://darksun.lunarpages.com/XCOM/xcomWindowed.png --[[User:SaintD|SaintD]] 00:34, 21 April 2009 (EDT)

[edit] I didn't realize you can just drag the Dxwnd window bigger. I still miss the advinterp3x from dosbox.

:I dunno exactly how DXWnd works but I think it may screw up aero stuff... I played with scale2x a bit and got that but it only works with DXWnd:
:[[Image:Scale2x.png]]

:When I try fullscreen, it looks like DirectX won't allow me to go to 640x400 resolution :( Any DX guru out there? [[User:Seb76|Seb76]] 14:36, 21 April 2009 (EDT)

::Can I get a copy of the new version? :) I can only use Dxwnd anyway. If you can boil the problem down I might be able to get some Direct X help. I know a couple guys who have been playing with XNA a lot. Can you create a stand alone sample program to illustrate your issue maybe?
:I uploaded this: [[Image:UFOExtender-dev.zip]]. It works only in window mode on my laptop, maybe you can give it a try? You'll most likely have to alt-tab out of the black screen though... [[User:Seb76|Seb76]] 11:08, 26 April 2009 (EDT)
:Edit: version updated with support for HQ4x (in 1280x800). Feedback appreciated... [[User:Seb76|Seb76]] 09:55, 3 May 2009 (EDT)

The above version works perfectly on my PC but only through DXWmd. I'd also like to note that using DXWnd eliminates fast speed issues in Battlescape for some reason. I'm really excited Seb is pulling this off. <3
:Uploaded a new version, you need to add a "HQ4x=1" line under the "Mod" section to enable it. [[User:Seb76|Seb76]] 15:36, 6 May 2009 (EDT)

Works perfect without the use of DXWnd, but there's some sort of frameskip feeling. Great work, this is getting better and better. :-)

Now the question is, how do you use DXWnd with the loader?
[[User:KingMob4313|KingMob4313]] 11:02, 12 August 2009 (EDT)

==Works but won't multitask==

Target system: prefab HP Vista with global data execution prevention. Problem is the same native, with D3D, and/or with HQ4X. (The two do combine nicely, visually, but a bit laggy for my tastes).

ALT-TAB terminates all further screen display on restore; the sea of blackness continues until Task Manager is used to kill the application, at which point D3D admits that it has "lost the device". (This is after the improved error reporting patch. Before, 0xc0000005 as Data Execution Prevention takes over.)

-- [[User:Zaimoni|Zaimoni]] 12:27, 12 August 2009 (CDT)

==Heavy laser mod==
My heavy laser only has the two new firing modes. Also, when I fire, the beams don't go where I point. They seem to be grouped correctly, just off in the wrong direction. [[User:SaintD:SaintD]]

:Yeah, it is a problem when you enable range based accuracy at the same time. I'll try to fix that when I get some time... [[User:Seb76|Seb76]] 14:25, 23 April 2009 (EDT)
:Made a new version. Can you try it and let me know if the problem is gone? [[User:Seb76|Seb76]] 09:19, 26 April 2009 (EDT)

::I tried it. The new modes now work, but Snap Mode is still missing from my HL. Also it's not clear the difference between burst and full auto since they both have the same accuracy and TU cost.--[[User:SaintD|SaintD]] 19:25, 29 April 2009 (EDT)

::: Hmmm, on mine the burst and full auto have different accuracies (80% and 60%, respectively); and they fire 5 and 8 rounds, also respectively. I believe the snap shot was taken out on purpose to coincide with the idea of the heavy laser as being more suited to being a support weapon. Of course the last part is conjecture on my part, but I am pretty certain it is not supposed to be there. --[[User:Talon81|Talon81]] 23:51, 29 April 2009 (EDT)

I am not the original poster in this heading, and I have not had the same problems with the heavy laser that others had (only one I had was about the Range Based Acc not affecting full auto), so I cannot confirm whether this patch has solved that. But I will tell you what you probably already know: everything is fuzzy, kinda like [ Mok's 2xSaI]. It is also a little bit jumpy. Due to that, I can't take advantage of the Funky Fire fix, or any other future fix, unless I am willing to deal with the fuzziness, or unless you create 2 runs; 1 with the Heavy Laser fix, and one without. --[[User:Talon81|Talon81]] 13:42, 28 April 2009 (EDT)
:Hum, I'm not sure I understand. What has the fuzziness to do with the HL fix? [[User:Seb76|Seb76]] 14:15, 28 April 2009 (EDT)

Wow, to think I almost didnt bother to post because I was sure you would already be aware of it. As soon as I updated your loader from 6 April (TFTD door fix) to 26 April (funky fire fix), everything got fuzzy. After that, I tried the update without funky fire (HL fix). Still fuzzy. Then I rolled back to the previous one (Initial Alien Base fix). No more fuzzy. I even went back to HL fix, then back again to Alien Base fix. Same deal. I will try using it on a fresh X-Com install without my other patches. But yeah, you should seriously install the patch I linked to in my above post. Will only take a minute to try. Looks VERY much like it (I know that many people have the fuzzy problem with that patch). --[[User:Talon81|Talon81]] 02:17, 29 April 2009 (EDT)

OK, it is indeed still fuzzy on a fresher copy of X-Com. It is not a genuine fresh install as I no longer have the disk, it is just the original files copied on my computer in another location. Furthermore, I forgot to mention there is also slight video garble (yes, even with the garble fix on) at the bottom of the menu screens. That in itself is not a problem as it is not throughout the game, and is only a few pixels in height. I can't wait to see if anyone else has these problems or if its just me. --[[User:Talon81|Talon81]] 02:27, 29 April 2009 (EDT)
:I have a crash with Mok's patch so I cannot check the problem. By fuzzy you mean something like the image is bilinearly filtered and all smoothed? [[User:Seb76|Seb76]] 17:20, 29 April 2009 (EDT)

I am a total programming/graphics newb, so I don't know if that is a good description or not. The UFO's for example, instead of being crosses, are blurbs that slightly change shape as they fly, and everything has softer transitions that make it look like it is done with pastels or something. I can tell you I tried to take a screen capture but it did not reflect the screen as it appears in game. In any case, unless other people have this same problem, I would not worry about it for my sake. If it is something you want to tackle anyway, just tell me what I can do to help you. --[[User:Talon81|Talon81]] 23:51, 29 April 2009 (EDT)
:Hum, are youe using the "dev" version instead of the official one? It features a scale2x filter that craps the image up.[[User:Seb76|Seb76]] 14:40, 30 April 2009 (EDT)

Not sure what you mean by "dev" version, but I am guessing you are referring to my version of CE. I do not know for sure, because it has been years since I got it, but I am guessing the answer is yes because mine runs in full screen without any mods. --[[User:Talon81|Talon81]] 12:22, 1 May 2009 (EDT)

Your newest version seems to have gotten rid of my problem. --[[User:Talon81|Talon81]] 12:32, 1 May 2009 (EDT)
:That's great ;-) By dev I was refering to the "dev" version of the loader linked on this page. It is an experimental version that uses scale2x with 640x400 resolution. [[User:Seb76|Seb76]] 12:53, 1 May 2009 (EDT)

== REng UFO with IDA ==

Hi Seb =)

I've just started working with IDA in an attempt to understand the inner workings of TACTICAL.EXE. I have never used IDA or related tools before, nor do I really know what I'm doing ;) I have removed the DOS/4GW loader and am examining the LE code currently.

So far my only progress (using DOSBox debugger) has been to isolate the calls in main() which display the equip screen and handle the interative section of the mission. You could say progress has been slow, as this has taken a couple days (including time spent figuring out the basics of IDA/DOSbox debug).

Would it be possible to see your notes? You will no doubt have discovered most (all?) functions and exactly what they do. If I could see this data (such as comments, renamed funtions, cleaned up code) it would take months off of the time I would need to understand the underlying assembler code.

I also recently discovered a plugin called HexRays for IDA. Do you use this? I'm really a newb so would love to get some input on which tools are best for this job.

My long, long-term goal will be to implement TACTICAL as a native windows program, as it would be a great project to have whilst learning to program (I should say I have some basic programming already, but nothing beyond a simple Windows game in Delphi).

Any advice is deeply appreciated mate =)

XCom forever!
--[[User:K9wazere|K9wazere]] 09:51, 17 June 2009 (EDT)
:Hi k9,
:Slow progress at the start is a normal thing. In the windows version I got help from the developers because they left a few error messages around to guide me during my initial analysis ^_^ I don't know about the DOS version, maybe they are also present.
:For the DB, just PM me an email address where I can send you the file (~1.7MB)... I gave a shot at HexRays (early versions), but I didn't find it that much useful in helping to understand what's going on. Well, if you're not used to asm, it may be interesting for you ;-) Still, for re-engineering a function it may prove useful. All in all, I'm just using a standard 5.2.0.908 version, it got everything I need. Also for debugging, I use DXWnd because breakpoints and fullscreen DX apps don't live well together...
:Good luck with your project,
:[[User:Seb76|Seb76]] 14:15, 17 June 2009 (EDT)

:::Thanks for that, Seb! I'm trying to understand how your loader and patcher works...

void InsertCall(int dst, void *func)
{
DWORD oldProtect;
DWORD *pOffset=(DWORD *)(((char *)dst)+1);

VirtualProtect((void *)dst,5,PAGE_EXECUTE_READWRITE,&oldProtect);
*(char *)dst=(char)0xE8;
*pOffset=(int)func-(int)dst-5;
VirtualProtect((void *)dst,5,oldProtect,&oldProtect);
}

::: This calculation here is interesting:

*pOffset=(int)func-(int)dst-5;

:::I assume 0xEA is assembler for CALL ... but then the reason for subtracting 'dst' from 'func' is not apparent. All in all I'm a bit confused as to how code in one area of memory (UFO Defense) can call code in another area of memory, belong to a different process (UFO Loader).
:The 0xEA is indeed the CALL opcode, but it is a relative jump so you must feed it the delta between source and destination (the 5 is the size of the CALL instruction itself that must be removed).
:The beauty of the thing is that the loader injects the code in the address space of the main executable image so you can call functions from/to it with no trouble :)

:::Can you suggest some good reading material to better understand this? Cheers!
:::--[[User:K9wazere|K9wazere]] 14:36, 20 June 2009 (EDT)
:You can search for DLL injection methods on the web, that's the name of the trick. In a nutshell I spawn the "UFO Defense" process in a suspended state, then use the CreateRemoteThread/LoadLibrary trick. HTH, [[User:Seb76|Seb76]] 14:48, 21 June 2009 (EDT)

== D3D ==

If I select the D3D option, UFO Defense and patcher.dll crash and generate a Windows Error Report. It won't let me copy and paste the contents unfortunately. My XCom machine is an old laptop, Win XP Pro 2003, Pentium III 851MHz, 376Mb RAM. I'm not sure what version (if any) of DirectX it has.

I'm still checking out the Save Equipment / Auto Flares mods. Very welcome! Once these are working there will be no reason for most people to use XComUtil. I will get back to you when I have specific feedback - but thanks again, Seb. [[User:Spike|Spike]] 12:59, 18 July 2009 (EDT)
:You need DirectX 9 installed (couldn't easily locate any older SDK, I'm sure I could've gotten away with DX7...), maybe I should make the code more robust and exit gracefully instead of crashing... [[User:Seb76|Seb76]] 13:04, 18 July 2009 (EDT)

Hmm. I've installed DirectX version 9 (March 2009 version) and with D3D enabled the Loader just fails silently; no error message, nothing in the event log. Maybe the install didn't work properly. I'll see if I can find some kind of DirectX test/verification utility somewhere. [[User:Spike|Spike]] 21:23, 19 July 2009 (EDT)

OK I ran the dxdiag utility which comes with DirectX 9.0c. This tests DirectDraw and Direct3D levels 7/8/9. There were no problems and no issues detected, apart from my laptop does not support hardware sound buffering (software only). I can send you the full dxdiag.txt report if it will help. When the Loader fails, all I see is a little black square in the top left, which I think is a normal part of the loading sequence (some kind of command window), and then nothing. [[User:Spike|Spike]] 21:39, 19 July 2009 (EDT)
:Might be related to using none power of two textures. Maybe your hardware does not support it? I'll add some more checks to make sure that's the problem.
:Edit: Can you try the latest version? I added some more error handling, can you tell me if you have an error message at some point? [[User:Seb76|Seb76]] 19:18, 20 July 2009 (EDT)
Unforunately I don't have access to the original laptop now, I won't do for a few months. I have tried on another PC (XP 2002 Professional SP3, DirectX9.0c, dxdiag tests all ok) and I also get a crash. Instead of dropping out right away, I see the smallish black square in the top left for a while, then I go to a full screen black or grey-black screen. This lasts for minutes. It doesn't eat up CPU and I can task switch out of it. I don't see any popup error messages and nothing in the event logs. When I kill UFO Defense the black full screen goes away. Sorry I know that's not much help. [[User:Spike|Spike]] 17:59, 22 July 2009 (EDT)

D3D mode isn't working for me either, I simply get a black screen. When I alt+tab out of it though I can see an error box titled 'D3D error' which tells me it 'Cannot create texture'. [[User:J'ordos|J'ordos]] 19:09, 8 August 2009 (EDT)
:edit: forgot to mention, I have directx 9.0c installed and dxdiag reports no problems. I have a Geforce2 MX *blushes*
:Do you know if this card supports non power of two textures? [[User:Seb76|Seb76]] 05:10, 9 August 2009 (EDT)
::no idea, but since your new version works fine with the D3D option on I assume it doesn't :) [[User:J'ordos|J'ordos]] 11:38, 9 August 2009 (EDT)
:That's great. Spike, does it fix your problems too? [[User:Seb76|Seb76]] 16:04, 9 August 2009 (EDT)
::Sorry for the late reply - yes that fixes my problems too, D3D is working fine now. Thanks, [[User:Spike|Spike]] 15:55, 26 August 2009 (EDT)

== Save equipment ==

Hi Seb. I've tried out the Save Equipment and Auto Flares (good idea by the way). I've seen some quirks. I had a few weapons (a Rifle and maybe a Pistol) that weren't loaded. Normally the game loads all weapons unless there isn't sufficient ammo. I moved some stuff around so this might have been due to me. So I restarted. Then I got a situation where:

*1 soldier had no weapons, just a grenade in a belt, even though there were Rifles and Auto Cannon (both with ammo) not allocated. Actually this soldier was showing 54/40 encumbrance from one grenade. Carrying a lot of "invisible" equipment!
*Heavy weapons (Auto Cannon, Heavy Cannon, Rocket Launcher) were allocated only once each. Spare heavy weapons were not allocated. The soldiers allocated the heavy weapons carried 3 spare ammo clips and were overloaded. Also, a weak soldier (strength 21 or so) was selected to carry the Auto Cannon and 3 spare clips.
*The mission appeared to be a night mission but no flares were allocated. (the previous mission, the Auto Flares worked fine). Maybe it was a Dusk mission? It looked dark out there.
*Also the game crashed when I moved the first guy out of the transport. Of course this is not necessarily related to using Save Equipment.

Actually, making sensible automatic rules for weapon and ammo allocation is hard to do, and a matter of personal taste, and this is really a different goal than just saving equipment allocations that have been picked manually by the player. So I'm probably being really unfair. Maybe it would be easier not to allocate any weapons other than what the player has picked?

Anyway I have a save game file for the 2nd game if that is any use to you for debugging. Cheers, [[User:Spike|Spike]] 18:53, 18 July 2009 (EDT)
:Thanks for the feedback, it got in the dev version for 2 months and nobody sent any comment so I figured I might as well put it in the official version ;-) I'm not surprised with the kind of problems you encountered, I got lots of 'em while making this... The crash at the start is most likely due to reaction fire.
:The autoflare feature should trigger at the same time as the visibility reduction caused by the night. Were you able to see up to 20 tiles away?
:As for the auto-allocation, I'm afraid there is no other easy option that I can see: when the mission starts, everybody is already equiped with the default stuff. I have to remove everything to be able to reassign items properly :( The default reequiping rules are quite simple: strength is not taken into account, and you require a set amount of free clips to be able to equip a weapon.
:I had a look at your savegame, but one just before the mission would be better. Also can you attach your ini file? Maybe some problems are caused by incompatibilities between mods. [[User:Seb76|Seb76]] 04:08, 19 July 2009 (EDT)
::OK uploaded what I hope is the right .ini file. Unfortunately that was my first savefile of the game, I don't have any earlier one. All I did was bought some guns 'n ammo and landed on the first (Roswell) crash site. The weirdest thing was the female soldier (Martha Stewart? or am I hallucinating?) with 54/40 encumbrance but only carrying one grenade. Could this be connected to [[Known_Bugs#Weightless_Loaded_Ammo|the problem you discovered in the game's weight routine]]? Anyway I will try and recreate the problem with more savefiles so you have a "before" and "after". [[User:Spike|Spike]] 07:15, 19 July 2009 (EDT)
:In your savegame I indeed see that the Maria chick is overweight, but if I bail out of the mission and go on a new one, she only have a grenade and a weight of 3... Another strange thing is that in the equip.ini file of the savegame, she's marked as having a large rocket loaded in the weapon that she's holding, but she has no weapon... Did you equip her with the rocket launcher and changed your mind afterward? [[User:Seb76|Seb76]] 11:27, 19 July 2009 (EDT)
::OK I restarted from a new game. I took lots of savegames after each step. Everyone has your default basic loadouts - loaded pistol or rifle, one reload, one grenade. I see a couple of anomalies. Look for Jacques. He is overweight despite only carrying a Rifle. Also, he is carrying a grenade that shows as Primed - it isn't. I even threw it to make sure - no explosion. Like Maria before him, Jacques is the last soldier in the equip.ini list. Also like Maria, Jacques is carrying more guns & ammo in equip.ini than are shown in the inventory screen. He has 5 items but they don't add up to the 54 or so Encumbrance he is showing. Like Maria, he is carrying ammo (type 13) in a slot1 (left hand) weapon that doesn't exist, and it seems to weigh about 20! The crazy encumbrance persists into the next turn and it is still there after I restore a savegame. I will upload a full set of play-by-play savegame files. I did move some equipment around for some guys in the later saves. But never for Jacques. [[User:Spike|Spike]] 21:10, 19 July 2009 (EDT)
:OK, I'll have a look at this, thanks for the effort.
:Edit: I could not reproduce the problem staight away: I see the crapped up weight if I load your tactical games, but when using the "i/b" one, Jacques is alright... Does this problem happens 100% of the time on your PC? Maybe it's a problem with the ini file handling (W2K3?), who knows... I'll keep trying. Feedback from XP/Vista users could be useful on this one. BTW are you using split binaries? [[User:Seb76|Seb76]] 15:44, 20 July 2009 (EDT)
::I've uploaded another save game, this time on a different PC (better XP version, CPU, RAM). Same symptoms - the last man has phantom equipment. Actually I notice the last TWO men have 2 items of equipment on them, but only visible one item shown in equip.ini. Also I keep forgetting to send the UFO Extender.ini file. My games don't use split binaries. I don't think it's a problem parsing the equip.ini file because the problem appears right away, if I save as my first action when the battlescape appears - the equip.ini already has the weirdness, and on the battlescape the soldier already has the weirdness. Although - let me check this - but I don't think the phantom equipment weirdness is there during the Equip Screen, it only appears when the actual Battlescape starts. So, if you pass the equipment information from the Equip screen to the Battlescape via the equip.ini file, that's a possibility. [[User:Spike|Spike]] 17:21, 20 July 2009 (EDT)
::Uploaded another New game, same/similar symptoms. This time the last guy is carrying weapons. But still, he is too heavy. The effect is NOT present in Equip Screen; his weight only increases once on the Battlescape. He is carrying a Rocket (object type 13) inside an invisible second weapon. So this could be a problem parsing the equip.ini file. [[User:Spike|Spike]] 17:38, 20 July 2009 (EDT)
::Last note tonight. The guy is overweight by 13 x 2 = 26 units. His equip.ini shows him carrying a phantom type 13 object (in a nonexistent 2nd weapon). Is this a coincidence? Maybe check the other savefiles and see if the last man was also overweight by 26 units, or by 2 x the index of the phantom item. [[User:Spike|Spike]] 18:00, 20 July 2009 (EDT)
:I uploaded a new version, can you check it out? [[User:Seb76|Seb76]] 19:16, 20 July 2009 (EDT)
:: Re tried with New game after your fix. Still seeing last 2 characters with incorrect weights. The weights were the same on the Equip screen as on the Battlescape. Excess weights are 6 and 3 units. Uploaded the save game. [[User:Spike|Spike]] 14:14, 21 July 2009 (EDT)
:Actually you're now hitting another bug: when putting a loaded gun to the floor, the ammo stays assigned to the soldier so its weight is still taken into account... [[User:Seb76|Seb76]] 15:21, 21 July 2009 (EDT)
::Yes you are right. In fact the weight errors were not 6 and 3 but 6 and 5 - the weight of heavy cannon ammo and auto cannon ammo, respectively. When I dropped the loaded heavy cannon and the loaded auto cannon, the encumbrance weights drop by 18 and 19 respectively. This is the weight of the unloaded weapon, not the correct weight of the loaded weapon. (Though normally, due to the buggy weight routine in the game, that *is* the actual (but incorrect) weight of the loaded weapon if you haven't yet unloaded it). So this is just a matter of ignoring the ammo weight from the soldier's encumbrance when dropping a loaded weapon. And it does look like the original problem has been fixed. [[User:Spike|Spike]] 18:18, 22 July 2009 (EDT)

Hmm more problems with Save Equipment. Ammo of all types seems to disappear. Eg I have 6 pistols and 6 pistol clips on the craft, but the Equip screen just gives me 6 empty pistols. Other weapons are short of ammo too. Is the Save feature perhaps "remembering" empty weapons (or loaded weapons) and somehow eliminating the clips. [[User:Spike|Spike]] 20:34, 18 August 2009 (EDT)
:This looks like an issue with ''UnloadClips''(). I noticed that the clip object's ''loaded_into'' is set to 0xff, but the ''not_loaded'' remains as 0. The game may see this as the clip still being loaded in an object, so the clip effectively disappears. --[[User:Mikawo|Mikawo]] 11:05, 19 August 2009 (EDT)
::This is possible. The wiki is wrong on these 2 fields BTW: it is in fact just one field (loaded_into signed extended to 16bit). I'll have a look at that. [[User:Seb76|Seb76]] 14:33, 19 August 2009 (EDT)

I think Mikawo is right. UnloadClips() should look something like this:

void UnloadClips()
{
obpos_dat *pObPos=pObpos_dat;

for(unsigned char i=0;i<170;i++)
{
if(pObPos->itemType != 0xff && pObPos->not_loaded == 0 && IsXComItem(i))
{
pObPos->loaded_into=0xff;
<big>'''pObPos->not_loaded=0xff;'''</big>
}
pObPos++;
}
}

Quite a few other functions in '''equipment.cpp''' use this check '''pObPos->not_loaded == 0xff''' so it is important to set this flag just for UFOExtender, regardless of whether the game needs it set (which it probably does). Eg items unloaded by UnloadClips will thereafter fail to be found by GetFreeItem, during execution of LoadSoldierEquipment. That probably explains the problems observed.
[[User:Spike|Spike]] 15:24, 26 August 2009 (EDT)

:I did some rework based on that. Do you have other problems? [[User:Seb76|Seb76]] 16:08, 30 August 2009 (EDT)

::Thanks Seb. This seems to be working mostly ok now. Some remaining smaller issues I have seen:

::* The weight calculation is so accurate, it is more accurate than the unmodified game. So the "weight free ammo" (the first clip loaded into a weapon, before the user takes any action in the Equip screen) is no longer weight free. Not sure if you want to "fix" this or not? It is debatable. Really, you have fixed a bug. But the normal game behaviour has changed. Maybe make the "weight free ammo" optional?
::* There is a weird glitch. If I unload a weapon, put it and the clip on the ground seperately, that works fine. But if I pick up the clip '''directly from the ground''' and load it straight into the weapon, then drop the weapon, the weight of the clip is still shown on the soldier. And actually the same thing happens with a clip that is first moved into the soldier's equipment. So in fact the problem is that a clip loaded into a weapon, doesn't get removed from the soldier weight when the weapon is dropped onto the ground. It happens even if the clip is pre-loaded by your routine.
::* Still outstanding - you can't use the right arrow to move onto a second screen of equipment. So you can't have more than one screenload of equipment on the ground. Or maybe you can, if you start the Equip screen with more than one screenload on the ground - I didn't check that.

::[[User:Spike|Spike]] 13:10, 1 September 2009 (EDT)

== Glitch with Alien Pets and Big Brother? ==

Hi Seb. I was trying to do some initial research on the idea of [[User:Spike#Tank mods|Tank mods]] but it looked like these 2 useful features of your Loader, Alien Pets and Big Brother, have both stopped working. Can you test this, on the latest version? I'm using a very recent version (last 2 weeks) but not the absolute latest as I have internet download problems.

Also, have you seen this new Wiki article: [[Enemy Unknown Extended]]. It is a package including your loader plus a few other odds and ends.

cheers,
[[User:Spike|Spike]] 11:16, 17 August 2009 (EDT)
:My mistake, I commented out that part of code a while ago and only recently noticed that. It was corrected one or two versions ago.
:The article is a good idea, it should allow less techies an easy start. [[User:Seb76|Seb76]] 13:51, 17 August 2009 (EDT)
:: OK cool yes the Hacks are back in place, thanks. [[User:Spike|Spike]] 20:34, 18 August 2009 (EDT)

== Alien Bleeding ==

Test results:

* 1-unit and 4-unit aliens can be healed by anyone (alien or human) holding a Medkit
* 4-unit aliens can be healed by standing in any of their 4 squares
* 4-unit aliens can only be healed while they are stunned. Pointing to their "control" square does not seem to work.
* 1-unit aliens can be healed either while conscious or while stunned
* Wounds on aliens can be correctly seen with Medkits
* The Medkit display shows a human silhouette regardless of the alien type, of course
* Healing aliens with Medkits, stops them from dying of wounds (not 100% tested but seems to be true)
* Aliens (large and small) seem to lose the correct amount of Health per turn from Wounds
* Aliens with wounds that are not treated, eventually die (not 100% tested but seems to be true)
* A Mind Probe can see if an alien has Wounds.

Anomalies:

* I had a lot more reports of Reapers dying than I would expect. I would not have expected any to die, and I had 3 reports of death by wounds. Even heavily wounded Reapers take a long time to die. In my test I was only shooting them with Pistols. Maybe there is a problem with the reporting? Maybe the death of the same Reaper was reported more than once? More testing needed on this.
* Question: should the death of an alien by wounds be reported, or should it die silently? Did I only see these messages because I was using Alien Pets, and so they were on "my" side?
:Regarding death reports, I enabled the dialog for aliens/civilians (it usually only shows up for xcom operatives) to help in testing. The final version will not show them. [[User:Seb76|Seb76]] 14:10, 3 September 2009 (EDT)

Caveats:
* I used the Alien Pets, Big Brother, and Alien Inventory hacks to do this test. I also hacked a save game to give me Pistols, Medkits, PsiAmps and Mind Probes. [[User:Spike|Spike]] 16:03, 3 September 2009 (EDT)

To Do:
* Test if aliens (small, large and mechanical) suffer from [[Fatal Wounds#Other effects of Fatal Wounds|other effects of wounds]], e.g. penalties to Energy, Accuracy, Time Units
* Do Cyberdisks, which have no legs or arms and probably no head, only ever receive Torso wounds?

* Question: Do Cyberdiscs and Sectopods receive Fatal Wounds? I'm wondering whether an unconscious Cyberdisc is safe to be around. Even if they didn't explode, Fatal Wounds would be stupid for a robot. If XCOM tanks can't end up leaking fuel and sparking dangerously, neither should enemy robots. [[User:Stubbs|Stubbs]]
: I think you can make a case for tanks and robots having "wounds", i.e. damage that gets progressively worse by itself. You can even make a case for them being "stunned" - temporarily non-operational. You can even make a case for it applying to alien robots but not to X-COM tanks, since alien robots all have some degree of organic component (which is why they can be Mind Controlled). But I still think you are right, neither effect should apply to machines, whether alien or human. As for your question, see the tests below:

Cyberdisk Bleeding Test Findings:
* Cyberdisks take Wounds (with Alien Bleeding option enabled)
* Cyberdisk wounds can be healed (though only after unit is stunned)
* Cyberdisks lose health from wounds
* Cyberdisks can die from wounds
* Cyberdisks don't seem to explode when they die from wounds ("has died from wounds" popup)

Cyberdisk Bleeding TestTest Caveats:
* Same caveats as previous tests (above), plus:
* The Cyberdisks were modified from Reapers using xcomutil :rpl
* Some Pistols were changed to Laser Rifles using xcomutil :chg
* (xcomutil was not installed in the game directory however, it was used from another location)
* The stats (Armour 34 all round, Health 120) appeared normal for Superhuman
* However the Cyberdisks seemed to fall too easily to Laser Rifle fire (e.g. 1 hit)
* Also, they seemed not to explode as often. This was because they were often stunned.
* Hard to tell in-game whether a Cyberdisk is dead or stunned. The graphic is the same, you can't use a Mind Probe, nor look on the ground, nor even check by changing sides.
* Actually there is one way to tell: stand over it and use a Medkit. Didn't think of that.

:Thanks for finding out, Spike. Autopsy text shows you are right about the Sectopod( but not about the Cyberdisc) having biomechanical components, but it's not like there are gallons of blood pumping around the thing to gush out. One thing: did you check both conscious and unconscious death-by-wounds for the Cyberdisc?

* Seb76: maybe robots receiving wounds was an oversight, or maybe you really do want robots to take wounds. In either case, it would be nice to have a separate option for this. My arguments against robot wounds are pretty simple: tanks do not receive them, the bled-out dialogue "X has died from a fatal wound" sounds silly for a robot that was never alive, and finally that a Medkit should not be able to heal a robot.
* If you want a sense of "the Sectopod's leg got damaged" or even "the tank's track was broken", perhaps robotic units could be 'wounded' by damaging max TUs.
* If, however, the above won't let weapon usage TU %s recalculate as TUs are lost (i.e. the units lose firing ability as well as walking), then certain values of Energy with the correct Energy usage modifier could emulate loss of speed without losing firing ability. Since Energy is returned at a rate of 1/3 of TUs, these units could have an Energy value of (slightly more than) exactly 1/3rd of their TUs. Their energy usage modifier is then changed to allow this small energy value to usually suffice. Now, when Energy is damaged, the units will be permanently slowed, but their weapons won't be affected.

[[User:Spike|Spike]] 08:22, 5 September 2009 (EDT)

== Hostile Civilians ==

This fix also seems to prevent the [[Exploiting_Mind_Control#Zombie's_Permanent_Control_of_Aliens_via_Stunning|Permanent Control of Aliens via Stunning]] Exploit - as was hoped for.

To Be Tested:

* [[Exploiting_Mind_Control#Resurrect Zombified Agents|Permanent Control of a Chryssalid/Tentaculat]]
* Various Mind Control bugs:
** [[Known_Bugs#Mind_Controlled_Soldiers_go_MIA]]
** [[Known_Bugs#Mind Controlled Aliens Count as MIA if you Abort]]

To Be Fixed:

* [[Exploiting_Mind_Control#Exponential Mind Control|Exponential Mind Control]]

[[User:Spike|Spike]] 16:16, 3 September 2009 (EDT)